From 5772650cc58891dc8f5208d307f539ffd1db7dbd Mon Sep 17 00:00:00 2001 From: Patrick Farrell Date: Thu, 2 Mar 2023 13:02:25 -0500 Subject: [PATCH] LU-16509 lnet: memcpy false positive in brw_test The flexible array at the end of srcp_bulk is triggering a false positive in fortified memcpy(). Quash it with unsafe_memcpy(). Signed-off-by: Patrick Farrell Change-Id: I13386c0a8e73b04af8d398aa49361bfdf6a05ad8 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/50185 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Shaun Tancheff Reviewed-by: Andreas Dilger Reviewed-by: Oleg Drokin --- lnet/selftest/brw_test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lnet/selftest/brw_test.c b/lnet/selftest/brw_test.c index 2e77d8f..8a15306 100644 --- a/lnet/selftest/brw_test.c +++ b/lnet/selftest/brw_test.c @@ -311,7 +311,9 @@ brw_client_prep_rpc(struct sfw_test_unit *tsu, struct lnet_process_id dest, if (rc != 0) return rc; - memcpy(&rpc->crpc_bulk, bulk, offsetof(struct srpc_bulk, bk_iovs[npg])); + unsafe_memcpy(&rpc->crpc_bulk, bulk, + offsetof(struct srpc_bulk, bk_iovs[npg]), + FLEXIBLE_OBJECT); if (opc == LST_BRW_WRITE) brw_fill_bulk(&rpc->crpc_bulk, flags, BRW_MAGIC); else -- 1.8.3.1