From 53f1c60bb72adc9d1e6980009a4bd3b2a61cc329 Mon Sep 17 00:00:00 2001 From: Patrick Farrell Date: Wed, 21 Feb 2024 15:00:14 -0500 Subject: [PATCH] LU-16695 llite: remove O_APPEND check for sync A check for O_APPEND in determining 'sync' or not was accidentally introduced. This forces O_APPEND writes to all be synchronous, which is of course wrong. Fixes: dad7079dfd ("LU-16695 llite: switch to ki_flags from f_flags") Signed-off-by: Patrick Farrell Change-Id: Iafae63ebda527834bd45d6fcbfb0cebb0340f4e4 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/54128 Reviewed-by: Alexander Boyko Reviewed-by: Alexey Lyashkov Reviewed-by: Andreas Dilger Reviewed-by: Shaun Tancheff Reviewed-by: Andrew Perepechko Reviewed-by: Oleg Drokin Tested-by: jenkins Tested-by: Maloo --- lustre/llite/file.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lustre/llite/file.c b/lustre/llite/file.c index bd2648f..1f1c940 100644 --- a/lustre/llite/file.c +++ b/lustre/llite/file.c @@ -1677,7 +1677,6 @@ void ll_io_init(struct cl_io *io, struct file *file, enum cl_io_type iot, if (iot == CIT_WRITE) { io->u.ci_wr.wr_append = iocb_ki_flags_check(flags, APPEND); io->u.ci_wr.wr_sync = !!(iocb_ki_flags_check(flags, SYNC) || - iocb_ki_flags_check(flags, APPEND) || iocb_ki_flags_check(flags, DSYNC) || IS_SYNC(inode)); } -- 1.8.3.1