From 4cf0b0fe443566940098308c2a9eb28fdb000166 Mon Sep 17 00:00:00 2001 From: Niu Yawei Date: Thu, 8 May 2014 10:38:53 +0800 Subject: [PATCH] libquota: fix dict_uint_cmp() dict_uint_cmp() returns an usigned int value in int type, which could mess the dict key comparison when the difference of two keys is greater than INT_MAX. Signed-off-by: Niu Yawei Signed-off-by: "Theodore Ts'o" --- lib/quota/mkquota.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/quota/mkquota.c b/lib/quota/mkquota.c index 9883216..ba8c2da 100644 --- a/lib/quota/mkquota.c +++ b/lib/quota/mkquota.c @@ -207,7 +207,12 @@ static int dict_uint_cmp(const void *a, const void *b) c = VOIDPTR_TO_UINT(a); d = VOIDPTR_TO_UINT(b); - return c - d; + if (c == d) + return 0; + else if (c > d) + return 1; + else + return -1; } static inline qid_t get_qid(struct ext2_inode *inode, int qtype) -- 1.8.3.1