From 49487b79da9ccc4a5f9d4e8f08c10ec9c8185a90 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Sun, 14 May 2006 17:29:00 -0400 Subject: [PATCH] Fixed signed vs. unsigned comparison warning in strncmp(). It's better to use memcmp() anyway given the code in question. Signed-off-by: "Theodore Ts'o" --- lib/blkid/ChangeLog | 5 +++++ lib/blkid/probe.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/blkid/ChangeLog b/lib/blkid/ChangeLog index 98542de..5a4d5ca 100644 --- a/lib/blkid/ChangeLog +++ b/lib/blkid/ChangeLog @@ -1,3 +1,8 @@ +2006-05-14 Theodore Tso + + * probe.c (probe_udf): Fix signed vs. unsigned lint warning; + better to use memcmp() rather than strncmp() anyway. + 2006-04-09 Theodore Ts'o * blkid_types.h.in, Makefile.in, tst_types.c: Use the asm_types.h diff --git a/lib/blkid/probe.c b/lib/blkid/probe.c index dcc6a6e..7edccca 100644 --- a/lib/blkid/probe.c +++ b/lib/blkid/probe.c @@ -587,10 +587,10 @@ static int probe_udf(struct blkid_probe *probe, NSR01 for UDF 1.00 NSR02 for UDF 1.50 NSR03 for UDF 2.00 */ - if (!strncmp(isosb->vd_id, "NSR0", 4)) + if (!memcmp(isosb->vd_id, "NSR0", 4)) return 0; for (m = udf_magic; *m; m++) - if (!strncmp(*m, isosb->vd_id, 5)) + if (!memcmp(*m, isosb->vd_id, 5)) break; if (*m == 0) return 1; -- 1.8.3.1