From 3f10707d90801ec84148b7f8ec6ad9c8470853ee Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Tue, 7 Jan 2014 00:55:02 -0500 Subject: [PATCH] libquota: add error checking to quota_write_inode() Addresses-Coverity-Id: #709476 Signed-off-by: "Theodore Ts'o" --- lib/quota/mkquota.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/lib/quota/mkquota.c b/lib/quota/mkquota.c index 3aa8100..b920f27 100644 --- a/lib/quota/mkquota.c +++ b/lib/quota/mkquota.c @@ -133,11 +133,16 @@ errcode_t quota_write_inode(quota_ctx_t qctx, int qtype) fs = qctx->fs; retval = ext2fs_get_mem(sizeof(struct quota_handle), &h); if (retval) { - log_err("Unable to allocate quota handle"); + log_err("Unable to allocate quota handle: %s", + error_message(retval)); goto out; } - ext2fs_read_bitmaps(fs); + retval = ext2fs_read_bitmaps(fs); + if (retval) { + log_err("Couldn't read bitmaps: %s", error_message(retval)); + goto out; + } for (i = 0; i < MAXQUOTAS; i++) { if ((qtype != -1) && (i != qtype)) @@ -171,7 +176,11 @@ errcode_t quota_write_inode(quota_ctx_t qctx, int qtype) fs->flags &= ~EXT2_FLAG_SUPER_ONLY; } - ext2fs_write_bitmaps(fs); + retval = ext2fs_write_bitmaps(fs); + if (retval) { + log_err("Couldn't write bitmaps: %s", error_message(retval)); + goto out; + } out: if (h) ext2fs_free_mem(&h); -- 1.8.3.1