From 3a1d6f3cc0f07070499beb7916f0c99de161eb7b Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Fri, 24 Jan 2003 23:11:29 -0500 Subject: [PATCH] save.c (blkid_save_cache): Use mkstemp() instead mktemp(). --- lib/blkid/ChangeLog | 4 ++++ lib/blkid/save.c | 7 ++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/blkid/ChangeLog b/lib/blkid/ChangeLog index 8a00f90..6791e98 100644 --- a/lib/blkid/ChangeLog +++ b/lib/blkid/ChangeLog @@ -1,3 +1,7 @@ +2003-01-24 Theodore Ts'o + + * save.c (blkid_save_cache): Use mkstemp() instead mktemp(). + 2002-10-04 Jordan Breeding * Forward port to e2fsprogs 1.30 diff --git a/lib/blkid/save.c b/lib/blkid/save.c index b55ab65..0b3f1ae 100644 --- a/lib/blkid/save.c +++ b/lib/blkid/save.c @@ -88,7 +88,7 @@ int blkid_save_cache(blkid_cache *cache, char *filename) char tmp[4096] = { '\0', }; char *opened = NULL; FILE *file = NULL; - int ret; + int fd, ret; if (!cache) return -BLKID_ERR_PARAM; @@ -123,8 +123,9 @@ int blkid_save_cache(blkid_cache *cache, char *filename) */ if (ret == 0 && S_ISREG(st.st_mode)) { snprintf(tmp, sizeof(tmp) - 1, "%s-XXXXXX", filename); - if (mktemp(tmp) == tmp && *tmp != '\0') { - file = fopen(tmp, "w"); + fd = mkstemp(tmp); + if (fd >= 0) { + file = fdopen(fd, "w"); opened = tmp; } } -- 1.8.3.1