From 392d7ff882e32e55708b5798fb2367856a112805 Mon Sep 17 00:00:00 2001
From: anserper <anserper>
Date: Thu, 18 Jun 2009 22:38:51 +0000
Subject: [PATCH] b=19912 i=Johann Lombardi

return negative error codes from {get,set}param_display, also print more sane error messages
---
 lustre/utils/lustre_cfg.c | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/lustre/utils/lustre_cfg.c b/lustre/utils/lustre_cfg.c
index 6df5597..d3c8dc8 100644
--- a/lustre/utils/lustre_cfg.c
+++ b/lustre/utils/lustre_cfg.c
@@ -611,6 +611,19 @@ static int getparam_cmdline(int argc, char **argv,
         return optind;
 }
 
+static char *globerrstr(int glob_rc)
+{
+        switch(glob_rc) {
+        case GLOB_NOSPACE:
+                return "Out of memory";
+        case GLOB_ABORTED:
+                return "Read error";
+        case GLOB_NOMATCH:
+                return "Found no match";
+        }
+        return "Unknown error";
+}
+
 static int getparam_display(struct param_opts *popt, char *pattern)
 {
         int rc;
@@ -623,8 +636,8 @@ static int getparam_display(struct param_opts *popt, char *pattern)
         rc = glob(pattern, GLOB_BRACE, NULL, &glob_info);
         if (rc) {
                 fprintf(stderr, "error: get_param: %s: %s\n",
-                        pattern, strerror(rc));
-                return rc;
+                        pattern, globerrstr(rc));
+                return -ESRCH;
         }
 
         buf = malloc(CFS_PAGE_SIZE);
@@ -769,8 +782,8 @@ static int setparam_display(struct param_opts *popt, char *pattern, char *value)
         rc = glob(pattern, GLOB_BRACE, NULL, &glob_info);
         if (rc) {
                 fprintf(stderr, "error: set_param: %s: %s\n",
-                        pattern, strerror(rc));
-                return rc;
+                        pattern, globerrstr(rc));
+                return -ESRCH;
         }
         for (i = 0; i  < glob_info.gl_pathc; i++) {
                 char *valuename = NULL;
-- 
1.8.3.1