From 349b8a37c5077086f1cd57c6b1b13ec275af6a43 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Wed, 21 Mar 2012 23:18:49 -0400 Subject: [PATCH] e2fsck: avoid unnecessary close/reopen for non-MMP filesystems For file systems that do not use MMP, there's no reason to close the file system and then re-open the file system a second time, since EXT2_FLAG_SKIP_MMP has no meaning for non-MMP file systems anyway. Signed-off-by: "Theodore Ts'o" Cc: Andreas Dilger --- e2fsck/unix.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/e2fsck/unix.c b/e2fsck/unix.c index 59c52ff..d0b10d4 100644 --- a/e2fsck/unix.c +++ b/e2fsck/unix.c @@ -1398,12 +1398,10 @@ failure: (flags & EXT2_FLAG_SKIP_MMP)) { if (e2fsck_check_mmp(fs, ctx)) fatal_error(ctx, 0); - } - /* - * Restart in order to reopen fs but this time start mmp. - */ - if (flags & EXT2_FLAG_SKIP_MMP) { + /* + * Restart in order to reopen fs but this time start mmp. + */ ext2fs_close(fs); ctx->fs = NULL; flags &= ~EXT2_FLAG_SKIP_MMP; -- 1.8.3.1