From 2af02215375802d67d8e28341cf408cd1e4ed4e6 Mon Sep 17 00:00:00 2001 From: Robert Yang Date: Mon, 14 Apr 2014 11:43:24 -0400 Subject: [PATCH] mke2fs.c: return error when failed to populate fs We need return retval when "mke2fs -d" failed, otherwise the "$?" would be 0 which is misleading. Signed-off-by: Robert Yang Signed-off-by: "Theodore Ts'o" Reviewed-by: Zheng Liu --- misc/mke2fs.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/misc/mke2fs.c b/misc/mke2fs.c index aecd5d5..60e7466 100644 --- a/misc/mke2fs.c +++ b/misc/mke2fs.c @@ -2990,10 +2990,11 @@ no_journal: retval = populate_fs(fs, EXT2_ROOT_INO, root_dir, EXT2_ROOT_INO); - if (retval) - fprintf(stderr, "%s", - _("\nError while populating file system")); - else if (!quiet) + if (retval) { + com_err(program_name, retval, "%s", + _("\nError while populating file system\n")); + exit(1); + } else if (!quiet) printf("%s", _("done\n")); } -- 1.8.3.1