From 26dacce72cb8d6d0d00e2377e255d9b3e900a09a Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Tue, 22 Jul 2014 12:40:30 -0400 Subject: [PATCH] e2fsck: free bh on csum verify error in do_one_pass Coverity (re-)spotted this; it was triaged as a false positive, but it seems pretty clear that the bh (which was just checked) isn't currently freed before the function exits. Signed-off-by: Eric Sandeen Signed-off-by: Theodore Ts'o --- e2fsck/recovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/e2fsck/recovery.c b/e2fsck/recovery.c index 54579c2..66d02b2 100644 --- a/e2fsck/recovery.c +++ b/e2fsck/recovery.c @@ -523,6 +523,7 @@ static int do_one_pass(journal_t *journal, !jbd2_descr_block_csum_verify(journal, bh->b_data)) { err = -EIO; + brelse(bh); goto failed; } -- 1.8.3.1