From 250bf9a7032fa13dad8eede903d17f3ec2e917de Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Fri, 10 Jan 2014 21:39:27 -0500 Subject: [PATCH] mke2fs, tune2fs: remove unneeded access() call Addresses-Coverity-Id: #709536 Addresses-Coverity-Id: #709535 Signed-off-by: "Theodore Ts'o" --- misc/mke2fs.c | 8 +++----- misc/tune2fs.c | 15 ++++++--------- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/misc/mke2fs.c b/misc/mke2fs.c index 10d3211..c45b42f 100644 --- a/misc/mke2fs.c +++ b/misc/mke2fs.c @@ -2254,11 +2254,9 @@ static int mke2fs_setup_tdb(const char *name, io_manager *io_ptr) sprintf(tdb_file, "%s/mke2fs-%s.e2undo", tdb_dir, dev_name); free(tmp_name); - if (!access(tdb_file, F_OK)) { - if (unlink(tdb_file) < 0) { - retval = errno; - goto errout; - } + if ((unlink(tdb_file) < 0) && (errno != ENOENT)) { + retval = errno; + goto errout; } set_undo_io_backing_manager(*io_ptr); diff --git a/misc/tune2fs.c b/misc/tune2fs.c index 568fb30..b8cd347 100644 --- a/misc/tune2fs.c +++ b/misc/tune2fs.c @@ -1856,15 +1856,12 @@ static int tune2fs_setup_tdb(const char *name, io_manager *io_ptr) goto alloc_fn_fail; sprintf(tdb_file, "%s/tune2fs-%s.e2undo", tdb_dir, dev_name); - if (!access(tdb_file, F_OK)) { - if (unlink(tdb_file) < 0) { - retval = errno; - com_err(program_name, retval, - _("while trying to delete %s"), - tdb_file); - free(tdb_file); - return retval; - } + if ((unlink(tdb_file) < 0) && (errno != ENOENT)) { + retval = errno; + com_err(program_name, retval, + _("while trying to delete %s"), tdb_file); + free(tdb_file); + return retval; } set_undo_io_backing_manager(*io_ptr); -- 1.8.3.1