From 2150278fa25f3fe8b8f29835ccd3079b608bb825 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Mon, 20 Dec 2010 10:57:29 -0500 Subject: [PATCH] libext2fs: fix potential free() of garbage in ext2fs_update_bb_inode() There was a potential of freeing an uninitialized pointer in rec.block_buf, which was pointed out by Namhyung Kim Signed-off-by: "Theodore Ts'o" --- lib/ext2fs/bb_inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ext2fs/bb_inode.c b/lib/ext2fs/bb_inode.c index 0b79b16..0b6c3dd 100644 --- a/lib/ext2fs/bb_inode.c +++ b/lib/ext2fs/bb_inode.c @@ -65,8 +65,7 @@ errcode_t ext2fs_update_bb_inode(ext2_filsys fs, ext2_badblocks_list bb_list) if (!fs->block_map) return EXT2_ET_NO_BLOCK_BITMAP; - rec.bad_block_count = 0; - rec.ind_blocks_size = rec.ind_blocks_ptr = 0; + memset(&rec, 0, sizeof(rec)); rec.max_ind_blocks = 10; retval = ext2fs_get_array(rec.max_ind_blocks, sizeof(blk_t), &rec.ind_blocks); -- 1.8.3.1