From 21400381d90a1e58443e1e2c3f52f8fd5550be9d Mon Sep 17 00:00:00 2001 From: Brian Behlendorf Date: Thu, 31 May 2007 11:30:47 -0400 Subject: [PATCH] [COVERITY] Free memory leak in mke2fs when parsing extended options Coverity ID: 34: Resource Leak Signed-off-by: Brian Behlendorf Signed-off-by: "Theodore Ts'o" --- misc/ChangeLog | 4 ++++ misc/mke2fs.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/misc/ChangeLog b/misc/ChangeLog index 4390c92..0923f94 100644 --- a/misc/ChangeLog +++ b/misc/ChangeLog @@ -1,3 +1,7 @@ +2007-05-31 Theodore Tso + + * mke2fs.c (parse_extended_opts): Free allocated buf on return + 2007-05-22 Theodore Tso * mke2fs.c (PRS): Make num_inodes use an unsigned long long type diff --git a/misc/mke2fs.c b/misc/mke2fs.c index 204b8a9..0292a64 100644 --- a/misc/mke2fs.c +++ b/misc/mke2fs.c @@ -841,6 +841,7 @@ static void parse_extended_opts(struct ext2_super_block *param, if (param->s_rev_level == EXT2_GOOD_OLD_REV) { fprintf(stderr, _("On-line resizing not supported with revision 0 filesystems\n")); + free(buf); exit(1); } param->s_feature_compat |= @@ -859,8 +860,10 @@ static void parse_extended_opts(struct ext2_super_block *param, "Valid extended options are:\n" "\tstride=\n" "\tresize=\n\n")); + free(buf); exit(1); } + free(buf); } static __u32 ok_features[3] = { -- 1.8.3.1