From 1fad18d7d4ff1e5b944733ba4f5e8074fb1c264b Mon Sep 17 00:00:00 2001 From: Andreas Dilger Date: Tue, 16 Apr 2024 15:34:14 -0600 Subject: [PATCH] EX-9611 lipe: ignore pylint warnings The Python-based lipe code is deprecated, but fails during building because of newer pylint warnings. Ignore errors from pylint during building until someone fixes them. Make the installation of pylint optional to simplify builds. Test-Parameters: trivial Signed-off-by: Andreas Dilger Change-Id: Ibd94f6ef5ef69b1fd597f40bbecca6e3c3fb8f02 Reviewed-on: https://review.whamcloud.com/c/ex/lustre-release/+/54861 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Feng Lei --- lipe/configure.ac | 2 +- lipe/pybuild/Makefile.am | 2 +- lipe/pylipe/Makefile.am | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lipe/configure.ac b/lipe/configure.ac index 3851f00..d195d25 100644 --- a/lipe/configure.ac +++ b/lipe/configure.ac @@ -165,7 +165,7 @@ fi # ------- check for pylint -------- AC_CHECK_PROGS([PYLINT], [pylint-3], []) if test "x$PYLINT" = "x"; then - AC_MSG_ERROR([pylint-3 is needed to check python coding style. Install pylint please.]) + AC_MSG_WARN([pylint-3 is needed to check python coding style. Install pylint please.]) fi # ------- check for libssh -------- diff --git a/lipe/pybuild/Makefile.am b/lipe/pybuild/Makefile.am index 51eccf6..4b4af0f 100644 --- a/lipe/pybuild/Makefile.am +++ b/lipe/pybuild/Makefile.am @@ -10,7 +10,7 @@ PYTHON_CHECKS = $(PYTHON_FILES:%=%.python_checked) CHECKS = $(PYTHON_CHECKS) %.python_checked: % ../.pylintrc - PYLINTRC=../.pylintrc $(PYLINT) --disable=I $< + -test -z "$(PYLINT)" || PYLINTRC=../.pylintrc $(PYLINT) --disable=I $< touch $@ check_clean-local: diff --git a/lipe/pylipe/Makefile.am b/lipe/pylipe/Makefile.am index 3bb5b3e..aa8ffd0 100644 --- a/lipe/pylipe/Makefile.am +++ b/lipe/pylipe/Makefile.am @@ -3,7 +3,7 @@ PYTHON_CHECKS = $(PYTHON_FILES:%=%.python_checked) CHECKS = $(PYTHON_CHECKS) %.python_checked: % ../.pylintrc - PYLINTRC=../.pylintrc $(PYLINT) --disable=I $< + -test -z "$(PYLINT)" || PYLINTRC=../.pylintrc $(PYLINT) --disable=I $< touch $@ check_clean-local: -- 1.8.3.1