From 1e9a36b00c0850cde88fd061248f768372eea7d8 Mon Sep 17 00:00:00 2001 From: Vladimir Saveliev Date: Mon, 1 Apr 2024 15:00:18 +0300 Subject: [PATCH] LU-15981 tests: add missing close in cascading_rw ONLY=cascading_rw OSTSIZE=200000 SLOW=yes sh parallel-scale.sh used to fail due to lack of space. cascading_rw missed a close before unlink, so disk space got consumed by open unlinked files. Add the missing close(). Change-Id: I9a8b3bfb9ff00e604ae0439433599b5050191b8e HPE-bug-id: LUS-10753 Test-Parameters: testlist=trivial testlist=parallel-scale envdefinitions=ONLY=cascading_rw Signed-off-by: Vladimir Saveliev Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/47823 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Andreas Dilger Reviewed-by: Alex Zhuravlev Reviewed-by: Oleg Drokin --- lustre/tests/mpi/cascading_rw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lustre/tests/mpi/cascading_rw.c b/lustre/tests/mpi/cascading_rw.c index 6c9d4f6..d69fd23 100644 --- a/lustre/tests/mpi/cascading_rw.c +++ b/lustre/tests/mpi/cascading_rw.c @@ -221,6 +221,8 @@ void rw_file(char *name, long stride, unsigned int seed) errno = 0; FAILF("Error: diff data read from %s", filename); } + if (close(fd) == -1) + FAILF("close of file %s", filename); } MPI_Barrier(MPI_COMM_WORLD); -- 1.8.3.1