From 1abdd04eb1d19488493022f81c03f5b80aa7fcc7 Mon Sep 17 00:00:00 2001 From: "Darrick J. Wong" Date: Sat, 24 Oct 2015 00:24:57 -0400 Subject: [PATCH] libext2fs: fix maximum bg overhead calculation with meta_bg enabled When meta_bg is enabled at mkfs time, we put at most one group descriptor block in each blockgroup. Unfortunately, the calculation of max overhead per bg doesn't know this, so mkfs fails when it isn't strictly necessary. Fix it, since Dave reported that he couldn't create a 500TB ext4 filesystem. Reported-by: Dave Chinner Signed-off-by: Darrick J. Wong Signed-off-by: Theodore Ts'o --- lib/ext2fs/initialize.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/ext2fs/initialize.c b/lib/ext2fs/initialize.c index 75fbf8e..f672a27 100644 --- a/lib/ext2fs/initialize.c +++ b/lib/ext2fs/initialize.c @@ -379,7 +379,12 @@ ipg_retry: * table, and the reserved gdt blocks. */ overhead = (int) (3 + fs->inode_blocks_per_group + - fs->desc_blocks + super->s_reserved_gdt_blocks); + super->s_reserved_gdt_blocks); + + if (fs->super->s_feature_incompat & EXT2_FEATURE_INCOMPAT_META_BG) + overhead++; + else + overhead += fs->desc_blocks; /* This can only happen if the user requested too many inodes */ if (overhead > super->s_blocks_per_group) { -- 1.8.3.1