From 193b21cad5a43b7f37ba67a7b7299564f0f68eef Mon Sep 17 00:00:00 2001 From: Andreas Dilger Date: Tue, 5 Mar 2024 15:01:14 -0700 Subject: [PATCH] LU-930 ptlrpc: remove spurious error messages Stop errors being printed when a disconnect RPC times out, since this error is ignored anyway, and adds no value to be printed. Remove -61 = -ENODATA error from seq_server_init() since this is an "expected" event for a new target and the error code is not useful. Test-Parameters: trivial Signed-off-by: Andreas Dilger Change-Id: I0f695409617061d46a1b910108cda05f863ebbe5 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/54285 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Arshad Hussain Reviewed-by: Sebastien Buisson Reviewed-by: Oleg Drokin --- lustre/fid/fid_handler.c | 4 ++-- lustre/ptlrpc/client.c | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lustre/fid/fid_handler.c b/lustre/fid/fid_handler.c index 93b5b01..95684d9 100644 --- a/lustre/fid/fid_handler.c +++ b/lustre/fid/fid_handler.c @@ -534,8 +534,8 @@ int seq_server_init(const struct lu_env *env, LUSTRE_SEQ_SPACE_RANGE; seq->lss_space.lsr_index = ss->ss_node_id; - LCONSOLE_INFO("%s: No data found on store. Initialize space: rc = %d\n", - seq->lss_name, rc); + LCONSOLE_INFO("%s: No data found on store. Initialize space.\n", + seq->lss_name); rc = seq_store_update(env, seq, NULL, 0); if (rc) { diff --git a/lustre/ptlrpc/client.c b/lustre/ptlrpc/client.c index 4c63dfd..3cfcad6 100644 --- a/lustre/ptlrpc/client.c +++ b/lustre/ptlrpc/client.c @@ -1336,8 +1336,10 @@ static bool ptlrpc_console_allow(struct ptlrpc_request *req, __u32 opc, int err) LASSERT(req->rq_reqmsg != NULL); /* Suppress particular reconnect errors which are to be expected. */ - if (opc == OST_CONNECT || opc == MDS_CONNECT || opc == MGS_CONNECT) { - /* Suppress timed out reconnect requests */ + if (opc == OST_CONNECT || opc == OST_DISCONNECT || + opc == MDS_CONNECT || opc == MDS_DISCONNECT || + opc == MGS_CONNECT || opc == MGS_DISCONNECT) { + /* Suppress timed out reconnect/disconnect requests */ if (lustre_handle_is_used(&req->rq_import->imp_remote_handle) || req->rq_timedout) return false; -- 1.8.3.1