From 164201425ec292ac25b93b61694fe6843cac74fd Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Fri, 12 Aug 2022 15:15:14 -0400 Subject: [PATCH] debugfs: make blocksize be unsigned in logdump.c Blocksize can never be negative, and this makes the use of signed vs unsigned variables for offsets be consistent. Signed-off-by: Theodore Ts'o --- debugfs/logdump.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/debugfs/logdump.c b/debugfs/logdump.c index 4154ef2..6b0133e 100644 --- a/debugfs/logdump.c +++ b/debugfs/logdump.c @@ -63,15 +63,15 @@ static void dump_journal(char *, FILE *, struct journal_source *); static void dump_descriptor_block(FILE *, struct journal_source *, char *, journal_superblock_t *, - unsigned int *, int, __u32, tid_t); + unsigned int *, unsigned int, __u32, tid_t); static void dump_revoke_block(FILE *, char *, journal_superblock_t *, - unsigned int, int, tid_t); + unsigned int, unsigned int, tid_t); static void dump_metadata_block(FILE *, struct journal_source *, journal_superblock_t*, unsigned int, unsigned int, unsigned int, - int, tid_t); + unsigned int, tid_t); static void dump_fc_block(FILE *out_file, char *buf, int blocksize, tid_t transaction, int *fc_done); @@ -649,11 +649,11 @@ static void dump_descriptor_block(FILE *out_file, struct journal_source *source, char *buf, journal_superblock_t *jsb, - unsigned int *blockp, int blocksize, + unsigned int *blockp, unsigned blocksize, __u32 maxlen, tid_t transaction) { - int offset, tag_size, csum_size = 0; + unsigned offset, tag_size, csum_size = 0; char *tagp; journal_block_tag_t *tag; unsigned int blocknr; @@ -709,7 +709,7 @@ static void dump_descriptor_block(FILE *out_file, static void dump_revoke_block(FILE *out_file, char *buf, journal_superblock_t *jsb EXT2FS_ATTR((unused)), unsigned int blocknr, - int blocksize EXT2FS_ATTR((unused)), + unsigned int blocksize, tid_t transaction) { unsigned int offset, max; @@ -727,10 +727,10 @@ static void dump_revoke_block(FILE *out_file, char *buf, header = (jbd2_journal_revoke_header_t *) buf; offset = sizeof(jbd2_journal_revoke_header_t); max = be32_to_cpu(header->r_count); - if (max > be32_to_cpu(jsb->s_blocksize)) { + if (max > blocksize) { fprintf(out_file, "Revoke block's r_count invalid: %u\b", max); - max = be32_to_cpu(jsb->s_blocksize); + max = blocksize; } while (offset < max) { @@ -775,7 +775,7 @@ static void dump_metadata_block(FILE *out_file, struct journal_source *source, unsigned int log_blocknr, unsigned int fs_blocknr, unsigned int log_tag_flags, - int blocksize, + unsigned int blocksize, tid_t transaction) { int retval; -- 1.8.3.1