From 0f67ab9b00c3949f257cd4e6081184858f245b4e Mon Sep 17 00:00:00 2001 From: Arshad Hussain Date: Mon, 22 Jan 2024 16:03:02 +0530 Subject: [PATCH] LU-17000 utils: In mydaemon() check after calling open() This patch adds check after calling open() in function mydaemon() instead of directly using the value Test-Parameters: trivial kerberos=true testlist=sanity-krb5 CoverityID: 397666 ("Argument cannot be negative") Fixes: d2d56f38da0 ("make HEAD from b_post_cmd3") Signed-off-by: Arshad Hussain Change-Id: Ic59414977029221e8618c5bb3320e95d39d9cded Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/53758 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Sebastien Buisson Reviewed-by: Andreas Dilger Reviewed-by: Timothy Day Reviewed-by: Oleg Drokin --- lustre/utils/gss/svcgssd.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lustre/utils/gss/svcgssd.c b/lustre/utils/gss/svcgssd.c index cdaf4ab..3b6cf2e 100644 --- a/lustre/utils/gss/svcgssd.c +++ b/lustre/utils/gss/svcgssd.c @@ -143,6 +143,11 @@ mydaemon(int nochdir, int noclose) if (noclose == 0) { tempfd = open("/dev/null", O_RDWR); + if (tempfd < 0) { + printerr(LL_ERR, "%s: open() failed: errno %d (%s)\n", + __func__, errno, strerror(errno)); + exit(1); + } dup2(tempfd, 0); dup2(tempfd, 1); dup2(tempfd, 2); -- 1.8.3.1