From 088f78e6ed20210c0ed265ff4bca6063e316bd90 Mon Sep 17 00:00:00 2001 From: Vladimir Saveliev Date: Sat, 7 Aug 2010 03:19:34 +0400 Subject: [PATCH 1/1] b=23271 handle e2fsck and lfsck return values to avoid test-framework.sh' trap i=jian.yu i=grev --- lustre/tests/test-framework.sh | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/lustre/tests/test-framework.sh b/lustre/tests/test-framework.sh index 194cbf3..a690b1c 100644 --- a/lustre/tests/test-framework.sh +++ b/lustre/tests/test-framework.sh @@ -2227,8 +2227,8 @@ run_e2fsck() { df > /dev/null # update statfs data on disk local cmd="$E2FSCK -d -v -f -n $MDSDB_OPT $ostdb_opt $target_dev" echo $cmd - do_node $node $cmd - local rc=${PIPESTATUS[0]} + local rc=0 + do_node $node $cmd || rc =$? [ $rc -le $FSCK_MAX_ERR ] || \ error "$cmd returned $rc, should be <= $FSCK_MAX_ERR" return 0 @@ -2272,15 +2272,14 @@ generate_db() { run_lfsck() { local cmd="$LFSCK_BIN -c -l --mdsdb $MDSDB --ostdb $OSTDB_LIST $MOUNT" echo $cmd - eval $cmd - local rc=${PIPESTATUS[0]} + local rc=0 + eval $cmd || rc=$? [ $rc -le $FSCK_MAX_ERR ] || \ error "$cmd returned $rc, should be <= $FSCK_MAX_ERR" echo "lfsck finished with rc=$rc" rm -rvf $MDSDB* $OSTDB* || true - - return $rc + return 0 } check_and_cleanup_lustre() { @@ -2288,8 +2287,7 @@ check_and_cleanup_lustre() { get_svr_devs generate_db if [ "$SKIP_LFSCK" == "no" ]; then - local rc=0 - run_lfsck || rc=$? + run_lfsck else echo "skip lfsck" fi -- 1.8.3.1