From 0688719a51d9c659399439535c5c3f8c66a7b577 Mon Sep 17 00:00:00 2001 From: Li Xi Date: Tue, 21 Dec 2021 18:24:30 +0800 Subject: [PATCH] LU-15388 osd-ldiskfs: wrong dot/dotdot FID for local agent Wrong FIDs are passed into osd_add_dot_dotdot_internal() in osd_create_local_agent_inode(). Local agent inode is created to satisfy e2fsck, and these two FIDs are not used anywhere, which won't cause any known issue. Signed-off-by: Li Xi Signed-off-by: Lai Siyao Change-Id: Ife39d539921a37994f9c6046ae066e1927154136 Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/45904 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Andreas Dilger Reviewed-by: Li Dongyang Reviewed-by: Oleg Drokin --- lustre/osd-ldiskfs/osd_handler.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lustre/osd-ldiskfs/osd_handler.c b/lustre/osd-ldiskfs/osd_handler.c index dd7dcf9..15dad8f 100644 --- a/lustre/osd-ldiskfs/osd_handler.c +++ b/lustre/osd-ldiskfs/osd_handler.c @@ -4031,9 +4031,9 @@ static struct inode *osd_create_local_agent_inode(const struct lu_env *env, if (!S_ISDIR(type)) RETURN(local); - rc = osd_add_dot_dotdot_internal(info, local, pobj->oo_inode, + rc = osd_add_dot_dotdot_internal(info, local, pobj->oo_inode, fid, lu_object_fid(&pobj->oo_dt.do_lu), - fid, oh); + oh); if (rc != 0) { CERROR("%s: "DFID" add dot dotdot error: rc = %d\n", osd_name(osd), PFID(fid), rc); @@ -6230,6 +6230,9 @@ static int osd_ea_lookup_rec(const struct lu_env *env, struct osd_object *obj, osd_add_oi_cache(osd_oti_get(env), osd_obj2dev(obj), id, fid); } + CDEBUG(D_INODE, DFID"/"DNAME" => "DFID"\n", + PFID(lu_object_fid(&obj->oo_dt.do_lu)), PNAME(&ln), + PFID(fid)); } else { rc = PTR_ERR(bh); } -- 1.8.3.1