From 057689505fb9bf37a1c10d8d6c91a408e21f1ef1 Mon Sep 17 00:00:00 2001 From: Emoly Liu Date: Mon, 31 Mar 2025 19:39:57 +0800 Subject: [PATCH] LU-18873 obdclass: add namelen check in encode_fn_len() Add namelen check in function encode_fn_len() to avoid coverity warnings. Fixes: d097fcc51b8 ("LU-18810 obd: add a parameter to enable filename encoding") Signed-off-by: Emoly Liu Change-Id: Ic1cc7238cd659254e286d8a595dc5203ae7dbc0b Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/58608 Reviewed-by: Andreas Dilger Reviewed-by: Timothy Day Reviewed-by: Oleg Drokin Tested-by: jenkins Tested-by: Maloo --- lustre/obdclass/obd_sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lustre/obdclass/obd_sysfs.c b/lustre/obdclass/obd_sysfs.c index eecf274..1006526 100644 --- a/lustre/obdclass/obd_sysfs.c +++ b/lustre/obdclass/obd_sysfs.c @@ -828,6 +828,8 @@ const char *encode_fn_len(const char *fname, size_t namelen) CDEBUG(D_TRACE, "Process filename at %p\n", &fname); if (!fname || !namelen || !obd_enable_fname_encoding) return fname; + if (unlikely(namelen > NAME_MAX)) + namelen = NAME_MAX; hash = lustre_hash_fnv_1a_64(fname, namelen); new_fn = fn_array[atomic_inc_return(&fn_index) & (FN_COUNT - 1)]; -- 1.8.3.1