From f8283515762a66e556c8ee253d694a8423ccd4a2 Mon Sep 17 00:00:00 2001 From: Arshad Hussain Date: Fri, 8 Mar 2024 08:58:43 +0530 Subject: [PATCH] LU-17621 lnet: fix conns_per_peer bounds check Logical opreator '||' would always result in 'TRUE', allowing any arbitrary conns_per_peer value to be set. Change Logical operator from '||' to '&&' to correctly compare that the value is within range. Test-Parameters: trivial testlist=sanity-lnet Fixes: 9b05e872482e ("LU-10391 lnet: support updating LNet local NI settings") CoverityID: 415060 ("Logically dead code") Signed-off-by: Arshad Hussain Change-Id: Ibcaf18060cae1fc62fe41ee6237abaad1fd2de7f Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/54326 Reviewed-by: Andreas Dilger Reviewed-by: Timothy Day Reviewed-by: James Simmons Reviewed-by: Chris Horn Reviewed-by: Oleg Drokin Tested-by: jenkins Tested-by: Maloo --- lnet/klnds/o2iblnd/o2iblnd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lnet/klnds/o2iblnd/o2iblnd.c b/lnet/klnds/o2iblnd/o2iblnd.c index 4277f8b..03fce9f 100644 --- a/lnet/klnds/o2iblnd/o2iblnd.c +++ b/lnet/klnds/o2iblnd/o2iblnd.c @@ -1382,7 +1382,7 @@ kiblnd_nl_set(int cmd, struct nlattr *attr, int type, void *data) break; case LNET_NET_O2IBLND_TUNABLES_ATTR_CONNS_PER_PEER: num = nla_get_s64(attr); - if (num > -1 || num < 128) + if (num >= 0 && num < 128) tunables->lnd_tun_u.lnd_o2ib.lnd_conns_per_peer = num; else rc = -ERANGE; -- 1.8.3.1