From: Kit Westneat Date: Sat, 6 May 2017 22:58:52 +0000 (-0400) Subject: LU-8294 gss: quiet cache_check return ENOENT warning X-Git-Tag: 2.9.58~40 X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=refs%2Fchanges%2F76%2F26976%2F2;p=fs%2Flustre-release.git LU-8294 gss: quiet cache_check return ENOENT warning gss_svc_upcall_handle_init spews a lot of error messages if GSS support has been compiled, but GSS is not being used. The current error message is not very useful, so this patch moves it to CDEBUG. Test-Parameters: trivial Signed-off-by: Kit Westneat Change-Id: Id58e3a9b5c702f8669f6659c6ff8e577391484de Reviewed-on: https://review.whamcloud.com/26976 Tested-by: Jenkins Tested-by: Maloo Reviewed-by: Andreas Dilger Reviewed-by: John L. Hammond Reviewed-by: Sebastien Buisson Reviewed-by: Oleg Drokin --- diff --git a/lustre/ptlrpc/gss/gss_svc_upcall.c b/lustre/ptlrpc/gss/gss_svc_upcall.c index e655aa1..e9ae2a3 100644 --- a/lustre/ptlrpc/gss/gss_svc_upcall.c +++ b/lustre/ptlrpc/gss/gss_svc_upcall.c @@ -977,16 +977,16 @@ cache_check: switch (rc) { case -ETIMEDOUT: case -EAGAIN: { - int valid; + int valid; - if (first_check) { - first_check = 0; + if (first_check) { + first_check = 0; - read_lock(&rsi_cache.hash_lock); + read_lock(&rsi_cache.hash_lock); valid = test_bit(CACHE_VALID, &rsip->h.flags); - if (valid == 0) + if (valid == 0) set_current_state(TASK_INTERRUPTIBLE); - read_unlock(&rsi_cache.hash_lock); + read_unlock(&rsi_cache.hash_lock); if (valid == 0) { unsigned long jiffies; @@ -996,16 +996,16 @@ cache_check: } cache_get(&rsip->h); goto cache_check; - } - CWARN("waited %ds timeout, drop\n", GSS_SVC_UPCALL_TIMEOUT); - break; - } - case -ENOENT: - CWARN("cache_check return ENOENT, drop\n"); - break; - case 0: - /* if not the first check, we have to release the extra - * reference we just added on it. */ + } + CWARN("waited %ds timeout, drop\n", GSS_SVC_UPCALL_TIMEOUT); + break; + } + case -ENOENT: + CDEBUG(D_SEC, "cache_check return ENOENT, drop\n"); + break; + case 0: + /* if not the first check, we have to release the extra + * reference we just added on it. */ if (!first_check) cache_put(&rsip->h, &rsi_cache); CDEBUG(D_SEC, "cache_check is good\n");