From: Alex Zhuravlev Date: Mon, 16 Sep 2013 17:11:09 +0000 (+0400) Subject: LU-3892 ofd: setattr doesn't need to return attributes X-Git-Tag: 2.4.93~23 X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=refs%2Fchanges%2F72%2F7672%2F2;p=fs%2Flustre-release.git LU-3892 ofd: setattr doesn't need to return attributes the root cause of the problem is that getattr finds the object being already destroyed, so we have transno from preceeding setattr and -ENOENT from getattr and this confuses OSP. there is actually no need in attributes in the reply. Signed-off-by: Alex Zhuravlev Change-Id: Ib059a443af164d0def58fdfbf41ab545c057cd10 Reviewed-on: http://review.whamcloud.com/7672 Tested-by: Hudson Tested-by: Maloo Reviewed-by: Mike Pershin Reviewed-by: Johann Lombardi Reviewed-by: Niu Yawei --- diff --git a/lustre/ofd/ofd_obd.c b/lustre/ofd/ofd_obd.c index fd1f6e0..aa2c48a 100644 --- a/lustre/ofd/ofd_obd.c +++ b/lustre/ofd/ofd_obd.c @@ -894,12 +894,6 @@ int ofd_setattr(const struct lu_env *env, struct obd_export *exp, ldlm_resource_putref(res); } - oinfo->oi_oa->o_valid = OBD_MD_FLID; - - /* Quota release needs uid/gid info */ - rc = ofd_attr_get(env, fo, &info->fti_attr); - obdo_from_la(oinfo->oi_oa, &info->fti_attr, - OFD_VALID_FLAGS | LA_UID | LA_GID); ofd_info2oti(info, oti); ofd_counter_incr(exp, LPROC_OFD_STATS_SETATTR, oti->oti_jobid, 1);