From: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Date: Wed, 1 Nov 2023 07:53:54 +0000 (+0530)
Subject: LU-17000 coverity: Fix Logically dead code under liblnetconfig.c
X-Git-Tag: 2.15.59~6
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=refs%2Fchanges%2F50%2F52950%2F2;p=fs%2Flustre-release.git

LU-17000 coverity: Fix Logically dead code under liblnetconfig.c

This patch fixes Logically dead code check reported
by coverity run.

CoverityID: 404752 ("Logically dead code")

Test-Parameters: trivial testlist=sanity-lnet
Signed-off-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Change-Id: I5a435324a19e04805c2a7c555ac2a0c1433ce2d0
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/52950
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
---

diff --git a/lnet/utils/lnetconfig/liblnetconfig.c b/lnet/utils/lnetconfig/liblnetconfig.c
index 24215be..c759f7b 100644
--- a/lnet/utils/lnetconfig/liblnetconfig.c
+++ b/lnet/utils/lnetconfig/liblnetconfig.c
@@ -1740,11 +1740,6 @@ int lustre_lnet_parse_nid_range(struct nid_node *head, char *nidstr,
 	while ((nid = strsep(&nidstr, "@")) != NULL) {
 		char *tmp = NULL, *tmp2 = NULL, *end = NULL;
 
-		if (!nid) {
-			*errmsg = "Unable to parse nidlist: no proper NID string";
-			return -ENOENT;
-		}
-
 		tmp = strchr(nid, '[');
 		tmp2 = strchr(nid, ']');