From: Oleg Drokin <green@whamcloud.com>
Date: Thu, 14 Nov 2024 06:50:00 +0000 (-0500)
Subject: LU-18445 libcfs: Remove msleep before panic for lbug
X-Git-Tag: 2.16.53~135
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=refs%2Fchanges%2F10%2F57010%2F3;p=fs%2Flustre-release.git

LU-18445 libcfs: Remove msleep before panic for lbug

If panic on lbug is set, do not sleep before calling
the panic() as it has very undesirable side effects.
Logs are getting rotated, racing threads continue moving
and get harder to understand what they were doing and
so on.

Test-Parameters: trivial
Fixes: 9f44a48b365 ("LU-17793 libcfs: fix objtool warning in lbug_with_loc()")
Change-Id: Idd49bda78c6441a11d3ea18cb053fd9755552604
Signed-off-by: Oleg Drokin <green@whamcloud.com>
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/57010
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Timothy Day <timday@amazon.com>
---

diff --git a/libcfs/libcfs/debug.c b/libcfs/libcfs/debug.c
index eaf70b9..1b8f28f 100644
--- a/libcfs/libcfs/debug.c
+++ b/libcfs/libcfs/debug.c
@@ -546,7 +546,6 @@ lbug_with_loc(struct libcfs_debug_msg_data *msgdata)
 
 	dump_stack();
 	if (libcfs_panic_on_lbug) {
-		msleep(cfs_time_seconds(6));
 		panic("LBUG");
 	} else
 		libcfs_debug_dumplog();