From: Theodore Ts'o <tytso@mit.edu>
Date: Thu, 11 Aug 2022 22:37:26 +0000 (-0400)
Subject: resize2fs: use ext2fs_get_arrayzero() instead of ext2fs_get_array() + memset()
X-Git-Tag: v1.46.6-rc1~26
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=ec30a439282fd4703d302f1f98fbad3ce9f99db2;p=tools%2Fe2fsprogs.git

resize2fs: use ext2fs_get_arrayzero() instead of ext2fs_get_array() + memset()

The use of ext2fs_get_arrayzero() to replace using ext2fs_get_array()
+ memset() does not result in any functional change, but it (a) is
slightly more efficient, and (b) makes it easier for Coverity to avoid
signalling a false positive.

Addresses-Coverity-Bug: 1500763
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/resize/extent.c b/resize/extent.c
index 4177c6f..82f69ca 100644
--- a/resize/extent.c
+++ b/resize/extent.c
@@ -50,14 +50,12 @@ errcode_t ext2fs_create_extent_table(ext2_extent *ret_extent, __u64 size)
 	extent->num = 0;
 	extent->sorted = 1;
 
-	retval = ext2fs_get_array(sizeof(struct ext2_extent_entry),
+	retval = ext2fs_get_arrayzero(sizeof(struct ext2_extent_entry),
 				extent->size, &extent->list);
 	if (retval) {
 		ext2fs_free_mem(&extent);
 		return retval;
 	}
-	memset(extent->list, 0,
-	       sizeof(struct ext2_extent_entry) * extent->size);
 	*ret_extent = extent;
 	return 0;
 }