From: Lai Siyao <laisiyao@whamcloud.com>
Date: Tue, 18 Oct 2011 05:08:47 +0000 (-0700)
Subject: LU-746 obdfilter-survey FAIL: test_1b ost4: hndls expected > 8, have 2
X-Git-Tag: v1_8_7_81_WC1~24
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=e93c4dae50fba04b8083a6afc5a7a79b8e4f0a44;p=fs%2Flustre-release.git

LU-746 obdfilter-survey FAIL: test_1b ost4: hndls expected > 8, have 2

obdfilter-survey.sh checks jbd proc stats after survey, but it
doesn't take obd cleanup time into account, so the stats
collected may not reflect the data of survey test. Save run time
of survey test, and collect stats of (run_time/4) ago to fix this.

Change-Id: Ib0b55693d13da172ca476ca79013a8a2e9dd81ca
Signed-off-by: Lai Siyao <laisiyao@whamcloud.com>
Reviewed-on: http://review.whamcloud.com/1534
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Johann Lombardi <johann@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Reviewed-by: Liang Zhen <liang@whamcloud.com>
---

diff --git a/lustre/tests/obdfilter-survey.sh b/lustre/tests/obdfilter-survey.sh
index cc84b4d..6d9060d 100644
--- a/lustre/tests/obdfilter-survey.sh
+++ b/lustre/tests/obdfilter-survey.sh
@@ -95,11 +95,14 @@ print_jbd () {
 check_jbd_values () {
 	local facet=$1
 	local thrhi=$2
+	local rtime=$3
 
 	# last two lines from history
 	# $4: run >= 5000
 	# $8: hndls >= thrhi * 2
-	local hist=("$(print_jbd history $facet | tail -3 | head -2)")
+	# display history of rtime/4 before, in case obd cleanup consumes time
+	local tlines=$((rtime / 5 / 4 + 1))
+	local hist=("$(print_jbd history $facet | tail -$tlines | head -1)")
 	echo "$hist"
 	local run=($(echo "${hist[*]}" | awk '{print $4}'))
 	local hndls=($(echo "${hist[*]}" | awk '{print $8}'))
@@ -117,10 +120,11 @@ check_jbd_values () {
 check_jbd_values_facets () {
 	local facets=$1
 	local thrhi=$2
+	local rtime=$3
 	local facet
 	local rc=0
 	for facet in  ${facets//,/ }; do
-		check_jbd_values $facet $thrhi || rc=$((rc+$?))
+		check_jbd_values $facet $thrhi $rtime || rc=$((rc+$?))
 	done
 	return $rc
 }
@@ -137,9 +141,14 @@ test_1b () {
 	save_lustre_params $(comma_list $(osts_nodes)) "obdfilter.${FSNAME}-*.sync_journal" >$param_file
 	do_nodesv $(comma_list $(osts_nodes)) lctl set_param obdfilter.${FSNAME}-*.sync_journal=0
 
+	local stime=$(date +%s)
 	thrlo=4 nobjhi=1 thrhi=4 obdflter_survey_run disk
+	local etime=$(date +%s)
+	# run time of obd survey
+	local rtime=$((etime - stime))
 
-	check_jbd_values_facets $(get_facets OST) 4 || rc=$((rc+$?))
+	echo "obd survey finished in $rtime seconds"
+	check_jbd_values_facets $(get_facets OST) 4 $rtime || rc=$((rc+$?))
 
 	restore_lustre_params < $param_file
 
@@ -165,9 +174,13 @@ test_2b () {
 	save_lustre_params $(comma_list $(osts_nodes)) "obdfilter.${FSNAME}-*.sync_journal" >$param_file
 	do_nodesv $(comma_list $(osts_nodes)) lctl set_param obdfilter.${FSNAME}-*.sync_journal=0
 
+	local stime=$(date +%s)
 	thrlo=4 nobjhi=1 thrhi=4 obdflter_survey_run netdisk
+	local etime=$(date +%s)
+	local rtime=$((etime - stime))
 
-	check_jbd_values_facets $(get_facets OST) 4 || rc=$((rc+$?))
+	echo "obd survey finished in $rtime seconds"
+	check_jbd_values_facets $(get_facets OST) 4 $rtime || rc=$((rc+$?))
 
 	restore_lustre_params < $param_file