From: adilger <adilger>
Date: Tue, 12 Mar 2002 23:08:32 +0000 (+0000)
Subject: Add comment about direct access to fs-internal data struct - it works for
X-Git-Tag: 0.4.2~531
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=c42df00cd7e237d18077f970ffbe1ef0e57d554c;p=fs%2Flustre-release.git

Add comment about direct access to fs-internal data struct - it works for
ext2 and ext3 (they happen to have the same layout) but it is dangerous.
Since it falls under the "hack - to be fixed with EA support" I didn't fix.
---

diff --git a/lustre/mds/mds_reint.c b/lustre/mds/mds_reint.c
index 7bf85ea..ee22076 100644
--- a/lustre/mds/mds_reint.c
+++ b/lustre/mds/mds_reint.c
@@ -85,6 +85,7 @@ static int mds_reint_setattr(struct mds_update_record *rec, struct ptlrpc_reques
 */
 static inline void mds_store_objid(struct inode *inode, __u64 *id)
 {
+        /* FIXME: it is only by luck that this works on ext3 */
 	memcpy(&inode->u.ext2_i.i_data, id, sizeof(*id));
 }