From: Sergey Cheremencev <sergey.cheremencev@hpe.com>
Date: Mon, 27 Dec 2021 16:45:51 +0000 (+0300)
Subject: LU-13639 tests: increase limit in sanity-quota t_2
X-Git-Tag: 2.15.0-RC1~51
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=c19acc6c2400fdf72ebfd2b07fd1da0bf5e21266;p=fs%2Flustre-release.git

LU-13639 tests: increase limit in sanity-quota t_2

If limit is equal to the least_qunit, slave target may
preacquire more quota while creating "limit number" of files
causing EDQUOT. Change limit from soft_qunit to 2 soft_qunit.
The patch also changes test behaviour - createmany is devided
to 2 parts. Firstly, it creates (limit-least_qunit) nodes and
check that there is no EDQUOT. Then it creates least_qunit
nodes and ignore the result of creating - it is a valid case
if it hits the limit. And only after that check that we
can't create nodes over quota.

Change-Id: Iad7c1cc05119c8d3e0f1cfc2adffb276d79f18c7
Test-Parameters: testgroup=review-dne-zfs-part-4
Test-Parameters: testlist=sanity-quota env=ONLY=2, ONLY_REPEAT=200
Signed-off-by: Sergey Cheremencev <sergey.cheremencev@hpe.com>
Reviewed-on: https://review.whamcloud.com/45943
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Alexander Boyko <alexander.boyko@hpe.com>
Reviewed-by: Andrew Perepechko <andrew.perepechko@hpe.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
---

diff --git a/lustre/tests/sanity-quota.sh b/lustre/tests/sanity-quota.sh
index 229aa73..f2a8490 100755
--- a/lustre/tests/sanity-quota.sh
+++ b/lustre/tests/sanity-quota.sh
@@ -1180,21 +1180,19 @@ run_test 1i "Quota pools: different limit and usage relations"
 
 # test inode hardlimit
 test_2() {
-	local TESTFILE="$DIR/$tdir/$tfile-0"
-	local LIMIT=$(do_facet mds1 $LCTL get_param -n \
+	local testfile="$DIR/$tdir/$tfile-0"
+	local least_qunit=$(do_facet mds1 $LCTL get_param -n \
 		qmt.$FSNAME-QMT0000.md-0x0.info |
 		awk '/least qunit/{ print $3 }')
-	local L2=$(do_facet mds1 $LCTL get_param -n \
-		qmt.$FSNAME-QMT0000.md-0x0.soft_least_qunit)
-
-	[ $L2 -le $LIMIT ] || LIMIT=$L2
+	local limit
 
-	[ "$SLOW" = "no" ] || LIMIT=$((LIMIT * 1024))
+	[ "$SLOW" = "no" ] && limit=$((least_qunit * 2)) ||
+		limit=$((least_qunit * 1024))
 
-	local FREE_INODES=$(mdt_free_inodes 0)
-	echo "$FREE_INODES free inodes on master MDT"
-	[ $FREE_INODES -lt $LIMIT ] &&
-		skip "not enough free inodes $FREE_INODES required $LIMIT"
+	local free_inodes=$(mdt_free_inodes 0)
+	echo "$free_inodes free inodes on master MDT"
+	[ $free_inodes -lt $limit ] &&
+		skip "not enough free inodes $free_inodes required $limit"
 
 	setup_quota_test || error "setup quota failed with $?"
 
@@ -1202,56 +1200,64 @@ test_2() {
 	set_mdt_qtype $QTYPE || error "enable mdt quota failed"
 
 	# test for user
-	log "User quota (inode hardlimit:$LIMIT files)"
-	$LFS setquota -u $TSTUSR -b 0 -B 0 -i 0 -I $LIMIT $DIR ||
+	log "User quota (inode hardlimit:$limit files)"
+	$LFS setquota -u $TSTUSR -b 0 -B 0 -i 0 -I $limit $DIR ||
 		error "set user quota failed"
 
 	# make sure the system is clean
-	local USED=$(getquota -u $TSTUSR global curinodes)
-	[ $USED -ne 0 ] && error "Used inodes($USED) for user $TSTUSR isn't 0."
+	local used=$(getquota -u $TSTUSR global curinodes)
+	[ $used -ne 0 ] && error "Used inodes($used) for user $TSTUSR isn't 0."
 
-	log "Create $LIMIT files ..."
-	$RUNAS createmany -m ${TESTFILE} $LIMIT ||
+	log "Create $((limit - least_qunit)) files ..."
+	$RUNAS createmany -m ${testfile} $((limit - least_qunit)) ||
 		quota_error u $TSTUSR "user create failure, but expect success"
+	# it is ok, if it fails on the last qunit
+	$RUNAS createmany -m ${testfile}_yyy $least_qunit || true
 	log "Create out of file quota ..."
-	$RUNAS touch ${TESTFILE}_xxx &&
+	$RUNAS touch ${testfile}_xxx &&
 		quota_error u $TSTUSR "user create success, but expect EDQUOT"
 
 	# cleanup
-	unlinkmany ${TESTFILE} $LIMIT || error "unlinkmany $TESTFILE failed"
-	rm -f ${TESTFILE}_xxx
+	unlinkmany ${testfile} $((limit - least_qunit)) ||
+		error "unlinkmany $testfile failed"
+	# if 2nd createmany got EDQUOT, not all of nodes would be created
+	unlinkmany ${testfile}_yyy $least_qunit || true
+	rm -f ${testfile}_xxx
 	wait_delete_completed
 
-	USED=$(getquota -u $TSTUSR global curinodes)
-	[ $USED -ne 0 ] && quota_error u $TSTUSR \
+	used=$(getquota -u $TSTUSR global curinodes)
+	[ $used -ne 0 ] && quota_error u $TSTUSR \
 		"user quota isn't released after deletion"
 	resetquota -u $TSTUSR
 
 	# test for group
 	log "--------------------------------------"
-	log "Group quota (inode hardlimit:$LIMIT files)"
-	$LFS setquota -g $TSTUSR -b 0 -B 0 -i 0 -I $LIMIT $DIR ||
+	log "Group quota (inode hardlimit:$limit files)"
+	$LFS setquota -g $TSTUSR -b 0 -B 0 -i 0 -I $limit $DIR ||
 		error "set group quota failed"
 
-	TESTFILE=$DIR/$tdir/$tfile-1
+	testfile=$DIR/$tdir/$tfile-1
 	# make sure the system is clean
-	USED=$(getquota -g $TSTUSR global curinodes)
-	[ $USED -ne 0 ] && error "Used inodes($USED) for group $TSTUSR isn't 0."
+	used=$(getquota -g $TSTUSR global curinodes)
+	[ $used -ne 0 ] && error "Used inodes($used) for group $TSTUSR isn't 0."
 
-	log "Create $LIMIT files ..."
-	$RUNAS createmany -m ${TESTFILE} $LIMIT ||
+	log "Create $limit files ..."
+	$RUNAS createmany -m ${testfile} $((limit - least_qunit)) ||
 		quota_error g $TSTUSR "group create failure, but expect success"
+	$RUNAS createmany -m ${testfile}_yyy $least_qunit ||
 	log "Create out of file quota ..."
-	$RUNAS touch ${TESTFILE}_xxx &&
+	$RUNAS touch ${testfile}_xxx &&
 		quota_error g $TSTUSR "group create success, but expect EDQUOT"
 
 	# cleanup
-	unlinkmany ${TESTFILE} $LIMIT || error "unlinkmany $TESTFILE failed"
-	rm -f ${TESTFILE}_xxx
+	unlinkmany ${testfile} $((limit - least_qunit)) ||
+		error "unlinkmany $testfile failed"
+	unlinkmany ${testfile}_yyy $least_qunit || true
+	rm -f ${testfile}_xxx
 	wait_delete_completed
 
-	USED=$(getquota -g $TSTUSR global curinodes)
-	[ $USED -ne 0 ] && quota_error g $TSTUSR \
+	used=$(getquota -g $TSTUSR global curinodes)
+	[ $used -ne 0 ] && quota_error g $TSTUSR \
 		"user quota isn't released after deletion"
 
 	resetquota -g $TSTUSR
@@ -1260,28 +1266,30 @@ test_2() {
 
 	# test for project
 	log "--------------------------------------"
-	log "Project quota (inode hardlimit:$LIMIT files)"
-	$LFS setquota -p $TSTPRJID -b 0 -B 0 -i 0 -I $LIMIT $DIR ||
+	log "Project quota (inode hardlimit:$limit files)"
+	$LFS setquota -p $TSTPRJID -b 0 -B 0 -i 0 -I $limit $DIR ||
 		error "set project quota failed"
 
-	TESTFILE=$DIR/$tdir/$tfile-1
+	testfile=$DIR/$tdir/$tfile-1
 	# make sure the system is clean
-	USED=$(getquota -p $TSTPRJID global curinodes)
-	[ $USED -ne 0 ] &&
-		error "Used inodes($USED) for project $TSTPRJID isn't 0"
+	used=$(getquota -p $TSTPRJID global curinodes)
+	[ $used -ne 0 ] &&
+		error "Used inodes($used) for project $TSTPRJID isn't 0"
 
 	change_project -sp $TSTPRJID $DIR/$tdir
-	log "Create $LIMIT files ..."
-	$RUNAS createmany -m ${TESTFILE} $((LIMIT-1)) || quota_error p \
-		$TSTPRJID "project create fail, but expect success"
+	log "Create $limit files ..."
+	$RUNAS createmany -m ${testfile} $((limit-least_qunit)) ||
+		quota_error p $TSTPRJID \
+			"project create fail, but expect success"
+	$RUNAS createmany -m ${testfile}_yyy $least_qunit || true
 	log "Create out of file quota ..."
-	$RUNAS touch ${TESTFILE}_xxx && quota_error p $TSTPRJID \
+	$RUNAS touch ${testfile}_xxx && quota_error p $TSTPRJID \
 		"project create success, but expect EDQUOT"
 	change_project -C $DIR/$tdir
 
 	cleanup_quota_test
-	USED=$(getquota -p $TSTPRJID global curinodes)
-	[ $USED -eq 0 ] || quota_error p $TSTPRJID \
+	used=$(getquota -p $TSTPRJID global curinodes)
+	[ $used -eq 0 ] || quota_error p $TSTPRJID \
 		"project quota isn't released after deletion"
 
 }