From: Theodore Ts'o <tytso@mit.edu>
Date: Thu, 11 Aug 2022 02:48:13 +0000 (-0400)
Subject: e2fsck: handle invalid percent expansions in the log filename
X-Git-Tag: v1.46.6-rc1~35
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=aa5732531f76e405a17415a4217f86cf8270d589;p=tools%2Fe2fsprogs.git

e2fsck: handle invalid percent expansions in the log filename

Add a missing default: case when expanding percent expansions in the
log file specified in /etc/e2fsck.conf.

Addresses-Coverity-Bug: 1500757
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/e2fsck/logfile.c b/e2fsck/logfile.c
index 7bdeae1..9d79eed 100644
--- a/e2fsck/logfile.c
+++ b/e2fsck/logfile.c
@@ -155,6 +155,9 @@ static void expand_percent_expression(e2fsck_t ctx, char ch,
 	case 'Y':
 		sprintf(buf, "%d", tm->tm_year + 1900);
 		break;
+	default:
+		sprintf(buf, "%%%c", ch);
+		break;
 	}
 	append_string(s, buf, 0);
 }