From: Serguei Smirnov Date: Mon, 31 Oct 2022 22:46:04 +0000 (-0700) Subject: LU-16282 lnet: fix debug message in lnet_discovery_event_reply X-Git-Tag: 2.15.53~75 X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=9f45a79e983c11defeaa1e377081a566d2ef41ea;p=fs%2Flustre-release.git LU-16282 lnet: fix debug message in lnet_discovery_event_reply The message in lnet_discovery_event_reply currently says "Peer X has discovery disabled" even though the same path may be taken if discovery is disabled locally. Change the debug message to indicate whether discovery is disabled on the peer side or locally. Test-Parameters: trivial testlist=sanity-lnet Signed-off-by: Serguei Smirnov Change-Id: I9c8be2286693c2bfc3f8cf67b6f3b8ab26f8258b Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/48997 Tested-by: jenkins Tested-by: Maloo Reviewed-by: Neil Brown Reviewed-by: Frank Sehr Reviewed-by: Oleg Drokin --- diff --git a/lnet/lnet/peer.c b/lnet/lnet/peer.c index 7eff033..b93f8dd 100644 --- a/lnet/lnet/peer.c +++ b/lnet/lnet/peer.c @@ -2607,6 +2607,7 @@ lnet_discovery_event_reply(struct lnet_peer *lp, struct lnet_event *ev) struct lnet_ping_buffer *pbuf; int infobytes; int rc; + bool ping_feat_disc; spin_lock(&lp->lp_lock); @@ -2648,10 +2649,12 @@ lnet_discovery_event_reply(struct lnet_peer *lp, struct lnet_event *ev) * The peer may have discovery disabled at its end. Set * NO_DISCOVERY as appropriate. */ - if (!(pbuf->pb_info.pi_features & LNET_PING_FEAT_DISCOVERY) || - lnet_peer_discovery_disabled) { - CDEBUG(D_NET, "Peer %s has discovery disabled\n", - libcfs_nidstr(&lp->lp_primary_nid)); + ping_feat_disc = pbuf->pb_info.pi_features & LNET_PING_FEAT_DISCOVERY; + if (!ping_feat_disc || lnet_peer_discovery_disabled) { + CDEBUG(D_NET, "Peer %s has discovery %s, local discovery %s\n", + libcfs_nidstr(&lp->lp_primary_nid), + ping_feat_disc ? "enabled" : "disabled", + lnet_peer_discovery_disabled ? "disabled" : "enabled"); /* Detect whether this peer has toggled discovery from on to * off and whether we can delete and re-create the peer. Peers