From: Lubomir Rintel <lkundrak@v3.sk>
Date: Fri, 23 Sep 2022 13:28:17 +0000 (+0200)
Subject: tune2fs: print error message when closing the fs fails
X-Git-Tag: v1.46.6~97
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=7c4bbd8f052af2b2be84293ddeff0d36e35b5a8f;p=tools%2Fe2fsprogs.git

tune2fs: print error message when closing the fs fails

I encountered an I/O error on writing the superblock on a drive:

  ...
  pwrite64(3, ..., 114688, 97844727808) = 114688
  fsync(3) = -1 EIO (Input/output error)
  close(3) = 0
  ...

The error was silently ignored, only indicated by the exit value. Let's
print an error message.

The error message was taken from mke2fs in order to reuse the
translations.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/misc/tune2fs.c b/misc/tune2fs.c
index f3ce443..b1e49b3 100644
--- a/misc/tune2fs.c
+++ b/misc/tune2fs.c
@@ -3450,5 +3450,13 @@ closefs:
 
 	if (feature_64bit)
 		convert_64bit(fs, feature_64bit);
-	return (ext2fs_close_free(&fs) ? 1 : rc);
+
+	retval = ext2fs_close_free(&fs);
+	if (retval) {
+		com_err("tune2fs", retval,
+			_("while writing out and closing file system"));
+		rc = 1;
+	}
+
+	return rc;
 }