From: shadow <shadow>
Date: Thu, 21 Jun 2007 07:20:24 +0000 (+0000)
Subject: fix IS_ERR implementation in liblustre.h for right detect errors
X-Git-Tag: v1_8_0_110~1513
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=68dea63794ade76802c5e98056032760dcde2254;p=fs%2Flustre-release.git

fix IS_ERR implementation in liblustre.h for right detect errors

b=12670
i=adilger
i=green
---

diff --git a/lustre/ChangeLog b/lustre/ChangeLog
index 61db18a..0fa8d69 100644
--- a/lustre/ChangeLog
+++ b/lustre/ChangeLog
@@ -313,6 +313,7 @@ Details    : A lock's skiplist need to be cleanup when it being unlinked
 
 Severity   : normal
 Bugzilla   : 11737
+Frequency  : always
 Description: Short directio read returns full requested size rather than
              actual amount read.
 Details    : Direct I/O operations should return actual amount of bytes
@@ -340,9 +341,17 @@ Details    : 2.6.22 has only one visble change, SLAB_CTOR_* constants is
 
 Severity   : minor
 Bugzilla   : 12747
+Frequency  : always
 Description: fix mal-formatted messages
 Details    : fix some mal-formatted DEBUG_REQ and LCONSOLE_ERROR_MSG messages 
 
+
+Severity   : minor
+Bugzilla   : 11737
+Frequency  : always in liblustre
+Description: wrong IS_ERR implementation in liblustre.h
+Details    : fix IS_ERR implementation in liblustre.h for right detect errors.
+
 --------------------------------------------------------------------------------
 
 2007-05-03  Cluster File Systems, Inc. <info@clusterfs.com>
diff --git a/lustre/include/liblustre.h b/lustre/include/liblustre.h
index a79f4703..1bcb9ab 100644
--- a/lustre/include/liblustre.h
+++ b/lustre/include/liblustre.h
@@ -145,7 +145,7 @@ static inline void *kmalloc(int size, int prot)
 #define GFP_HIGHUSER 1
 #define GFP_ATOMIC 1
 #define GFP_NOFS 1
-#define IS_ERR(a) ((unsigned long)(a) < 1000)
+#define IS_ERR(a) ((unsigned long)(a) > (unsigned long)-1000L)
 #define PTR_ERR(a) ((long)(a))
 #define ERR_PTR(a) ((void*)((long)(a)))