From: isaac <isaac>
Date: Fri, 12 Sep 2008 14:11:32 +0000 (+0000)
Subject: -   added a comment on a Darwin quirk.
X-Git-Tag: v1_9_80~109
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=6556906a665f9e88840dd20d2abcc0fa9dfcd379;p=fs%2Flustre-release.git

-   added a comment on a Darwin quirk.
---

diff --git a/lnet/klnds/socklnd/socklnd_cb.c b/lnet/klnds/socklnd/socklnd_cb.c
index efec018..63ce0a8 100644
--- a/lnet/klnds/socklnd/socklnd_cb.c
+++ b/lnet/klnds/socklnd/socklnd_cb.c
@@ -761,10 +761,9 @@ ksocknal_queue_tx_locked (ksock_tx_t *tx, ksock_conn_t *conn)
         tx->tx_conn = conn;
         ksocknal_conn_addref(conn); /* +1 ref for tx */
 
-        /* 
-         * NB Darwin: SOCK_WMEM_QUEUED()->sock_getsockopt() will take
-         * a blockable lock(socket lock), so SOCK_WMEM_QUEUED can't be
-         * put in spinlock. 
+        /*
+         * FIXME: SOCK_WMEM_QUEUED and SOCK_ERROR could block in __DARWIN8__
+         * but they're used inside spinlocks a lot.
          */
         bufnob = SOCK_WMEM_QUEUED(conn->ksnc_sock);
         spin_lock_bh (&sched->kss_lock);