From: Andreas Dilger <andreas.dilger@intel.com>
Date: Fri, 18 Mar 2016 08:03:45 +0000 (-0600)
Subject: LU-7867 debugfs: fix check for out-of-bound xattr value
X-Git-Tag: v1.42.13.wc6~14
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=5ea47a9efd5faf9de59be693dc6fa6a8fc6529b7;p=tools%2Fe2fsprogs.git

LU-7867 debugfs: fix check for out-of-bound xattr value

Since upsream commit 8a546777119c9c0, the validity check for in-inode
xattrs in internal_dump_inode_extra() has been incorrectly checking
the value size.  The value can go right to the end of the inode.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Change-Id: Id20861df7c973d76a433aecfcfd125ca32ce117b
Reviewed-on: http://review.whamcloud.com/18999
Reviewed-by: Fan Yong <fan.yong@intel.com>
Tested-by: Jenkins
Reviewed-by: Matt Ezell <ezellma@ornl.gov>
---

diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
index c8eff77..73fedc4 100644
--- a/debugfs/debugfs.c
+++ b/debugfs/debugfs.c
@@ -610,7 +610,7 @@ static void internal_dump_inode_extra(FILE *out,
 					entry->e_value_inum != 0;
 
 			if (name + entry->e_name_len >= end ||
-			    (!ea_inode && value + entry->e_value_size >= end) ||
+			    (!ea_inode && value + entry->e_value_size > end) ||
 			    (char *)next >= end) {
 				fprintf(out, "invalid EA entry in inode\n");
 				return;