From: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Date: Thu, 12 Oct 2023 08:46:43 +0000 (-0400)
Subject: LU-17000 coverity: Fix leak under mgc_request.c
X-Git-Tag: 2.15.59~43
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=5b88c865b994b84060ffb5eaada5e9777ddaf675;p=fs%2Flustre-release.git

LU-17000 coverity: Fix leak under mgc_request.c

This patch fixes resource leak error reported
by coverity run.

CoverityID: 403113 ("Resource leak"): mgc_request.c

Test-Parameters: trivial
Signed-off-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Change-Id: Ie569a18cbacdb48c186d38ccc466ce86eeb1b28f
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/52656
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
---

diff --git a/lustre/mgc/mgc_request.c b/lustre/mgc/mgc_request.c
index 2efb6c1..0d4777c 100644
--- a/lustre/mgc/mgc_request.c
+++ b/lustre/mgc/mgc_request.c
@@ -1319,6 +1319,9 @@ static int mgc_apply_recover_logs(struct obd_device *mgc,
 		if (cname == NULL) {
 			CERROR("mgc %s: invalid logname %s\n",
 			       mgc->obd_name, obdname);
+			if (entry->mne_nid_type == 0)
+				OBD_FREE_PTR_ARRAY(nidlist,
+						   entry->mne_nid_count);
 			break;
 		}