From: Manish Katiyar <mkatiyar@gmail.com>
Date: Wed, 1 Oct 2008 23:42:57 +0000 (-0400)
Subject: resize2fs: Fix potential memory corruption in ext2fs_progress_init()
X-Git-Tag: v1.41.2~8
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=520a17729242e11408df6bd73c873860b63988bf;p=tools%2Fe2fsprogs.git

resize2fs: Fix potential memory corruption in ext2fs_progress_init()

Check the return value of ext2fs_get_mem, since prog isn't initialized
so checking may miss a failed memory allocation.

Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---

diff --git a/resize/sim_progress.c b/resize/sim_progress.c
index a575633..e7dba88 100644
--- a/resize/sim_progress.c
+++ b/resize/sim_progress.c
@@ -83,7 +83,7 @@ errcode_t ext2fs_progress_init(ext2_sim_progmeter *ret_prog,
 	errcode_t		retval;
 
 	retval = ext2fs_get_mem(sizeof(struct ext2_sim_progress), &prog);
-	if (!prog)
+	if (retval)
 		return retval;
 	memset(prog, 0, sizeof(struct ext2_sim_progress));