From: eeb <eeb>
Date: Tue, 20 Sep 2005 17:19:08 +0000 (+0000)
Subject: *    removed lnet_parse() rc ambiguity: 0 on success
X-Git-Tag: v1_7_100~1^25~6^2~172
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=376b23a7fc929cb86e4a862f4a3862061e7a7f77;p=fs%2Flustre-release.git

*    removed lnet_parse() rc ambiguity: 0 on success
---

diff --git a/lnet/klnds/qswlnd/qswlnd_cb.c b/lnet/klnds/qswlnd/qswlnd_cb.c
index 86b9af9..fc8a93c 100644
--- a/lnet/klnds/qswlnd/qswlnd_cb.c
+++ b/lnet/klnds/qswlnd/qswlnd_cb.c
@@ -1374,7 +1374,6 @@ kqswnal_recv (lnet_ni_t      *ni,
                 kqswnal_rx_decref(krx);
                 return -EPROTO;
         }
-        /* NB lnet_parse() has already flipped *hdr */
 
         /* It must be OK to kmap() if required */
         LASSERT (kiov == NULL || !in_interrupt ());
diff --git a/lnet/lnet/lib-move.c b/lnet/lnet/lib-move.c
index 9c255df..acb34a8 100644
--- a/lnet/lnet/lib-move.c
+++ b/lnet/lnet/lib-move.c
@@ -719,7 +719,7 @@ lnet_ni_recv(lnet_ni_t *ni, void *private, lnet_msg_t *msg, int delayed,
         
         rc = (ni->ni_lnd->lnd_recv)(ni, private, msg, delayed,
                                     niov, iov, kiov, offset, mlen, rlen);
-        if (rc != 0)
+        if (rc < 0)
                 lnet_finalize(ni, msg, rc);
 }
 
@@ -806,7 +806,7 @@ lnet_ni_send(lnet_ni_t *ni, lnet_msg_t *msg)
                  (msg->msg_txcredit && msg->msg_peertxcredit));
 
         rc = (ni->ni_lnd->lnd_send)(ni, priv, msg);
-        if (rc != 0)
+        if (rc < 0)
                 lnet_finalize(ni, msg, rc);
         
         if (recv)
@@ -1453,7 +1453,7 @@ lnet_parse_get(lnet_ni_t *ni, lnet_msg_t *msg)
         msg->msg_recvaftersend = 1;
         
         rc = lnet_send(ni, msg);
-        if (rc != 0) {
+        if (rc < 0) {
                 /* didn't get as far as lnet_ni_send() */
                 CERROR("%s: Unable to send REPLY for GET from %s: %d\n",
                        libcfs_nid2str(ni->ni_nid), libcfs_id2str(src), rc);
@@ -1875,7 +1875,7 @@ lnet_parse(lnet_ni_t *ni, lnet_hdr_t *hdr, lnet_nid_t from_nid, void *private)
 
  drop:
         lnet_drop_message(ni, private, payload_length);
-        return ENOENT;
+        return 0;
 }
 
 int
@@ -2110,7 +2110,7 @@ LNetGet(lnet_handle_md_t mdh,
         LNET_UNLOCK();
 
         rc = lnet_send(NULL, msg);
-        if (rc != 0) {
+        if (rc < 0) {
                 CERROR("error sending GET to %s: %d\n",
                        libcfs_id2str(target), rc);
                 lnet_finalize (NULL, msg, rc);