From: Eric Sandeen <sandeen@redhat.com>
Date: Tue, 22 Jul 2014 16:40:30 +0000 (-0400)
Subject: e2fsck: free bh on csum verify error in do_one_pass
X-Git-Tag: v1.43-WIP-2015-05-18~276
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=26dacce72cb8d6d0d00e2377e255d9b3e900a09a;p=tools%2Fe2fsprogs.git

e2fsck: free bh on csum verify error in do_one_pass

Coverity (re-)spotted this; it was triaged as a false positive,
but it seems pretty clear that the bh (which was just checked)
isn't currently freed before the function exits.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/e2fsck/recovery.c b/e2fsck/recovery.c
index 54579c2..66d02b2 100644
--- a/e2fsck/recovery.c
+++ b/e2fsck/recovery.c
@@ -523,6 +523,7 @@ static int do_one_pass(journal_t *journal,
 			    !jbd2_descr_block_csum_verify(journal,
 							  bh->b_data)) {
 				err = -EIO;
+				brelse(bh);
 				goto failed;
 			}