From: Andreas Dilger <adilger@whamcloud.com>
Date: Wed, 13 Sep 2023 05:12:18 +0000 (-0600)
Subject: LU-17010 lfsck: don't dump stack repeatedly
X-Git-Tag: 2.15.5-RC1~21
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=1d54befc9bc69188092dc4ef18d301c43b9ca8cd;p=fs%2Flustre-release.git

LU-17010 lfsck: don't dump stack repeatedly

If there are transactions started with LFSCK in dry-run mode, don't
dump the stack repeatedly, as this can spam the console logs and
significantly hurt performance.

Lustre-commit: dc360cd3eff20618f243ab89097a62f8ecf2c929
Lustre-change: https://review.whamcloud.com/52356

Test-Parameters: trivial testlist=sanity-lfsck
Fixes: 0c1ae1cb9c ("LU-13124 scrub: check for multiple linked file")
Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
Change-Id: I0b0d64911453dc8ab947e284656311b5d0300c1e
Reviewed-by: Hongchao Zhang <hongchao@whamcloud.com>
Reviewed-by: Lai Siyao <lai.siyao@whamcloud.com>
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/54853
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
---

diff --git a/lustre/lfsck/lfsck_internal.h b/lustre/lfsck/lfsck_internal.h
index e6a8a48..8e048e7 100644
--- a/lustre/lfsck/lfsck_internal.h
+++ b/lustre/lfsck/lfsck_internal.h
@@ -1549,10 +1549,13 @@ lfsck_trans_create(const struct lu_env *env, struct dt_device *dev,
 		   struct lfsck_instance *lfsck)
 {
 	if (lfsck->li_bookmark_ram.lb_param & LPF_DRYRUN) {
+		static int count;
+
 		CERROR("%s: transaction is being created in DRYRUN mode!\n",
 		       lfsck_lfsck2name(lfsck));
 
-		dump_stack();
+		if (count++ < 3)
+			dump_stack();
 		return ERR_PTR(-EINVAL);
 	}