From: Jakub Wilk <jwilk@jwilk.net>
Date: Wed, 27 Dec 2023 08:08:05 +0000 (+0100)
Subject: e4crypt: fix spurious "Success" error message
X-Git-Tag: v1.47.1-rc1~49
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=1275bbaaea7ffd42346789f945c2f4dcddbfbbc8;p=tools%2Fe2fsprogs.git

e4crypt: fix spurious "Success" error message

Before:

    # e4crypt set_policy 0000000000000000 /dev/null
    /dev/null is not a directory
    /dev/null: Success

After:

    # e4crypt set_policy 0000000000000000 /dev/null
    /dev/null: Not a directory

Signed-off-by: Jakub Wilk <jwilk@jwilk.net>
Link: https://lore.kernel.org/r/20231227080805.6801-1-jwilk@jwilk.net
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/misc/e4crypt.c b/misc/e4crypt.c
index 67d25d8..af90704 100644
--- a/misc/e4crypt.c
+++ b/misc/e4crypt.c
@@ -144,7 +144,7 @@ static void validate_paths(int argc, char *argv[], int path_start_index)
 		if (ret < 0)
 			goto invalid;
 		if (!S_ISDIR(st.st_mode)) {
-			fprintf(stderr, "%s is not a directory\n", argv[x]);
+			errno = ENOTDIR;
 			goto invalid;
 		}
 	}