From: Theodore Ts'o <tytso@mit.edu>
Date: Sun, 24 Jun 2018 18:00:14 +0000 (-0400)
Subject: e2fsck: add error-checking when unlink tdb file for dir_info
X-Git-Tag: v1.44.3-rc1~12
X-Git-Url: https://git.whamcloud.com/?a=commitdiff_plain;h=0abe5745b6e400ad36f5d1659846e2c557837ba7;p=tools%2Fe2fsprogs.git

e2fsck: add error-checking when unlink tdb file for dir_info

Fixes-Coverity-Bug: 1308365
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/e2fsck/dirinfo.c b/e2fsck/dirinfo.c
index b29f7e9..cceadac 100644
--- a/e2fsck/dirinfo.c
+++ b/e2fsck/dirinfo.c
@@ -326,7 +326,9 @@ void e2fsck_free_dir_info(e2fsck_t ctx)
 		if (ctx->dir_info->tdb)
 			tdb_close(ctx->dir_info->tdb);
 		if (ctx->dir_info->tdb_fn) {
-			unlink(ctx->dir_info->tdb_fn);
+			if (unlink(ctx->dir_info->tdb_fn) < 0)
+				com_err("e2fsck_free_dir_info", errno,
+					_("while freeing dir_info tdb file"));
 			free(ctx->dir_info->tdb_fn);
 		}
 #endif