Whamcloud - gitweb
LU-13419 osc: Remove unnecessary spinlock assertion 57/56957/2
authorPatrick Farrell <paf0187@gmail.com>
Mon, 11 Nov 2024 16:54:33 +0000 (11:54 -0500)
committerOleg Drokin <green@whamcloud.com>
Thu, 2 Jan 2025 20:40:41 +0000 (20:40 +0000)
This spinlock assertion notably increases the time spent in
getting grant with many threads to few OSCs, but adds
little value.  Remove it.

Test-Parameters: trivial
Signed-off-by: Patrick Farrell <paf0187@gmail.com>
Change-Id: I596b9ac349a6dd1a633c6671d19d15bbf61b9fa2
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/56957
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Zhenyu Xu <bobijam@hotmail.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/osc/osc_cache.c

index a7a97e7..22cd013 100644 (file)
@@ -1347,7 +1347,6 @@ static int osc_completion(const struct lu_env *env, struct osc_object *osc,
 static void osc_consume_write_grant(struct client_obd *cli,
                                    struct brw_page *pga)
 {
-       assert_spin_locked(&cli->cl_loi_list_lock);
        LASSERT(!(pga->bp_flag & OBD_BRW_FROM_GRANT));
        cli->cl_dirty_pages++;
        pga->bp_flag |= OBD_BRW_FROM_GRANT;
@@ -1362,7 +1361,6 @@ static void osc_release_write_grant(struct client_obd *cli,
 {
        ENTRY;
 
-       assert_spin_locked(&cli->cl_loi_list_lock);
        if (!(pga->bp_flag & OBD_BRW_FROM_GRANT)) {
                EXIT;
                return;