static void
cfs_hash_buckets_free(struct cfs_hash_bucket **buckets,
- int bkt_size, int prev_size, int size)
+ int bkt_size, int prev_size, int size)
{
- int i;
+ int i;
- for (i = prev_size; i < size; i++) {
- if (buckets[i] != NULL)
- LIBCFS_FREE(buckets[i], bkt_size);
- }
+ for (i = prev_size; i < size; i++)
+ LIBCFS_FREE(buckets[i], bkt_size);
- LIBCFS_FREE(buckets, sizeof(buckets[0]) * size);
+ LIBCFS_FREE(buckets, sizeof(buckets[0]) * size);
}
/*
__free_page(dest[i].bv_page);
}
- if (src != NULL)
- CFS_FREE_PTR_ARRAY(src, GNILND_MAX_IOV);
- if (dest != NULL)
- CFS_FREE_PTR_ARRAY(dest, GNILND_MAX_IOV);
+ CFS_FREE_PTR_ARRAY(src, GNILND_MAX_IOV);
+ CFS_FREE_PTR_ARRAY(dest, GNILND_MAX_IOV);
return rc;
}
{
kgn_smsg_seq_iter_t *gseq = iter;
- if (gseq != NULL)
- LIBCFS_FREE(gseq, sizeof(*gseq));
+ LIBCFS_FREE(gseq, sizeof(*gseq));
}
static void *
{
kgn_conn_seq_iter_t *gseq = iter;
- if (gseq != NULL)
- LIBCFS_FREE(gseq, sizeof(*gseq));
+ LIBCFS_FREE(gseq, sizeof(*gseq));
}
static void *
{
kgn_peer_seq_iter_t *gseq = iter;
- if (gseq != NULL)
- LIBCFS_FREE(gseq, sizeof(*gseq));
+ LIBCFS_FREE(gseq, sizeof(*gseq));
}
static void *
if (conn->ibc_rx_pages != NULL)
kiblnd_unmap_rx_descs(conn);
- if (conn->ibc_rxs != NULL)
- CFS_FREE_PTR_ARRAY(conn->ibc_rxs, IBLND_RX_MSGS(conn));
+ CFS_FREE_PTR_ARRAY(conn->ibc_rxs, IBLND_RX_MSGS(conn));
- if (conn->ibc_connvars != NULL)
- LIBCFS_FREE(conn->ibc_connvars, sizeof(*conn->ibc_connvars));
+ LIBCFS_FREE(conn->ibc_connvars, sizeof(*conn->ibc_connvars));
if (conn->ibc_hdev != NULL)
kiblnd_hdev_decref(conn->ibc_hdev);
int wrq_sge = *kiblnd_tunables.kib_wrq_sge;
list_del(&tx->tx_list);
- if (tx->tx_pages != NULL)
- CFS_FREE_PTR_ARRAY(tx->tx_pages, LNET_MAX_IOV);
- if (tx->tx_frags != NULL)
- CFS_FREE_PTR_ARRAY(tx->tx_frags,
- IBLND_MAX_RDMA_FRAGS);
- if (tx->tx_wrq != NULL)
- CFS_FREE_PTR_ARRAY(tx->tx_wrq,
- IBLND_MAX_RDMA_FRAGS);
+ CFS_FREE_PTR_ARRAY(tx->tx_pages, LNET_MAX_IOV);
+ CFS_FREE_PTR_ARRAY(tx->tx_frags,
+ IBLND_MAX_RDMA_FRAGS);
+ CFS_FREE_PTR_ARRAY(tx->tx_wrq,
+ IBLND_MAX_RDMA_FRAGS);
if (tx->tx_sge != NULL) {
/* +1 is for the lnet header/message itself */
CFS_FREE_PTR_ARRAY(tx->tx_sge,
(IBLND_MAX_RDMA_FRAGS *
wrq_sge + 1));
}
- if (tx->tx_rd != NULL)
- LIBCFS_FREE(tx->tx_rd,
- offsetof(struct kib_rdma_desc,
- rd_frags[IBLND_MAX_RDMA_FRAGS]));
+ LIBCFS_FREE(tx->tx_rd,
+ offsetof(struct kib_rdma_desc,
+ rd_frags[IBLND_MAX_RDMA_FRAGS]));
}
CFS_FREE_PTR_ARRAY(tpo->tpo_tx_descs, pool->po_size);
ksocknal_peer_decref(peer_ni);
failed_1:
- if (hello != NULL)
- LIBCFS_FREE(hello, offsetof(struct ksock_hello_msg,
- kshm_ips[LNET_INTERFACES_NUM]));
+ LIBCFS_FREE(hello, offsetof(struct ksock_hello_msg,
+ kshm_ips[LNET_INTERFACES_NUM]));
LIBCFS_FREE(conn, sizeof(*conn));
}
out:
- if (name != NULL)
- LIBCFS_FREE(name, args->lstio_dbg_nmlen + 1);
+ LIBCFS_FREE(name, args->lstio_dbg_nmlen + 1);
return rc;
}
rc = -EINVAL;
}
- if (name != NULL)
- LIBCFS_FREE(name, args->lstio_sta_nmlen + 1);
+ LIBCFS_FREE(name, args->lstio_sta_nmlen + 1);
return rc;
}
rc = (copy_to_user(args->lstio_tes_retp, &ret,
sizeof(ret))) ? -EFAULT : 0;
out:
- if (batch_name != NULL)
- LIBCFS_FREE(batch_name, args->lstio_tes_bat_nmlen + 1);
+ LIBCFS_FREE(batch_name, args->lstio_tes_bat_nmlen + 1);
- if (src_name != NULL)
- LIBCFS_FREE(src_name, args->lstio_tes_sgrp_nmlen + 1);
+ LIBCFS_FREE(src_name, args->lstio_tes_sgrp_nmlen + 1);
- if (dst_name != NULL)
- LIBCFS_FREE(dst_name, args->lstio_tes_dgrp_nmlen + 1);
+ LIBCFS_FREE(dst_name, args->lstio_tes_dgrp_nmlen + 1);
- if (param != NULL)
- LIBCFS_FREE(param, args->lstio_tes_param_len);
+ LIBCFS_FREE(param, args->lstio_tes_param_len);
return rc;
}
/* hold groups so nobody can change them */
return rc;
out:
- if (test != NULL)
- LIBCFS_FREE(test, offsetof(struct lstcon_test,
- tes_param[paramlen]));
+ LIBCFS_FREE(test, offsetof(struct lstcon_test,
+ tes_param[paramlen]));
if (dst_grp != NULL)
lstcon_group_decref(dst_grp);
spin_unlock(&imp->imp_lock);
RETURN(0);
out_free:
- if (imp_conn)
- OBD_FREE(imp_conn, sizeof(*imp_conn));
+ OBD_FREE(imp_conn, sizeof(*imp_conn));
out_put:
ptlrpc_connection_put(ptlrpc_conn);
RETURN(rc);
err_ldlm:
ldlm_put_ref();
err:
- if (cli->cl_mod_tag_bitmap != NULL)
- OBD_FREE(cli->cl_mod_tag_bitmap,
- BITS_TO_LONGS(OBD_MAX_RIF_MAX) * sizeof(long));
+ OBD_FREE(cli->cl_mod_tag_bitmap,
+ BITS_TO_LONGS(OBD_MAX_RIF_MAX) * sizeof(long));
cli->cl_mod_tag_bitmap = NULL;
RETURN(rc);
ldlm_put_ref();
- if (cli->cl_mod_tag_bitmap != NULL)
- OBD_FREE(cli->cl_mod_tag_bitmap,
- BITS_TO_LONGS(OBD_MAX_RIF_MAX) * sizeof(long));
+ OBD_FREE(cli->cl_mod_tag_bitmap,
+ BITS_TO_LONGS(OBD_MAX_RIF_MAX) * sizeof(long));
cli->cl_mod_tag_bitmap = NULL;
RETURN(0);
target->obd_name, abs(timeout) / 60,
abs(timeout) % 60, target->obd_name);
- if (buf != NULL)
- OBD_FREE(buf, size);
+ OBD_FREE(buf, size);
}
out_already:
OBD_SLAB_FREE(res->lr_itree, ldlm_interval_tree_slab,
sizeof(*res->lr_itree) * LCK_MODE_NUM);
} else if (res->lr_type == LDLM_IBITS) {
- if (res->lr_ibits_queues != NULL)
- OBD_FREE_PTR(res->lr_ibits_queues);
+ OBD_FREE_PTR(res->lr_ibits_queues);
}
call_rcu(&res->lr_rcu, __ldlm_resource_free);
lfsck_instance_put(env, lfsck);
if (rc != 0) {
- if (it != NULL)
- OBD_FREE_PTR(it);
+ OBD_FREE_PTR(it);
it = (struct lfsck_orphan_it *)ERR_PTR(rc);
}
goto repeat_fid2path;
out_fid2path:
- if (remote_gf != NULL)
- OBD_FREE(remote_gf, remote_gf_size);
+ OBD_FREE(remote_gf, remote_gf_size);
RETURN(rc);
}
lod->lod_child = lu2dt_dev(lod->lod_child_exp->exp_obd->obd_lu_dev);
out:
- if (data)
- OBD_FREE_PTR(data);
- if (nextdev)
- OBD_FREE(nextdev, len);
+ OBD_FREE_PTR(data);
+ OBD_FREE(nextdev, len);
RETURN(rc);
}
if (rc != 0)
GOTO(out, rc);
out:
- if (slave_lmm != NULL)
- OBD_FREE_PTR(slave_lmm);
+ OBD_FREE_PTR(slave_lmm);
RETURN(rc);
}
rc = lod_sub_xattr_set(env, dt_object_child(dt),
&lmv_buf, XATTR_NAME_LMV, fl, th);
out:
- if (slave_lmm != NULL)
- OBD_FREE_PTR(slave_lmm);
+ OBD_FREE_PTR(slave_lmm);
RETURN(rc);
}
struct lov_request,
rq_link)) != NULL) {
list_del_init(&req->rq_link);
- if (req->rq_oi.oi_osfs)
- OBD_FREE_PTR(req->rq_oi.oi_osfs);
+ OBD_FREE_PTR(req->rq_oi.oi_osfs);
OBD_FREE_PTR(req);
}