Whamcloud - gitweb
LU-18522 utils: fix -export-dynamic flag 34/57334/6
authorSohei Koyama <skoyama@ddn.com>
Sun, 8 Dec 2024 15:09:35 +0000 (00:09 +0900)
committerOleg Drokin <green@whamcloud.com>
Mon, 16 Dec 2024 08:20:39 +0000 (08:20 +0000)
When compiled with clang it fails with
`unknown argument: '-export-dynamic'`.
'-export-dynamic' is supported by gcc but not by clang.
Change to '-Wl,--export-dynamic' instead, which both supports.
-Wl, specifies the flags to be passed to the linker.

Signed-off-by: Sohei Koyama <skoyama@ddn.com>
Change-Id: I35830c0fec5387d532252478a402735ba2ad2dbf
Test-Parameters: trivial
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/57334
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Reviewed-by: Timothy Day <timday@amazon.com>
Reviewed-by: Patrick Farrell <pfarrell@whamcloud.com>
lustre/utils/Makefile.am

index 3537756..21dbd1c 100644 (file)
@@ -184,7 +184,7 @@ libmount_utils_zfs_a_CPPFLAGS := -DHAVE_IOCTL_IN_UNISTD_H $(ZFS_LIBZFS_INCLUDE)
 if PLUGINS
 lib_LTLIBRARIES += libmount_utils_zfs.la
 libmount_utils_zfs.la : libmount_utils_zfs.a
-       $(CC) $(LDFLAGS) $(MNTMODLDFLAGS) -shared -export-dynamic -pthread \
+       $(CC) $(LDFLAGS) $(MNTMODLDFLAGS) -shared -Wl,--export-dynamic -pthread \
                         $(ZFS_LIBZFS_LDFLAGS) -o mount_osd_zfs.so \
                         `$(AR) -t libmount_utils_zfs.a` \
                         $(MNTMODLIBS) $(ZFS_LIBZFS_LIBS)
@@ -204,7 +204,7 @@ libmount_utils_ldiskfs_a_CPPFLAGS :=
 if PLUGINS
 lib_LTLIBRARIES += libmount_utils_ldiskfs.la
 libmount_utils_ldiskfs.la : libmount_utils_ldiskfs.a
-       $(CC) $(LDFLAGS) $(MNTMODLDFLAGS) -shared -export-dynamic \
+       $(CC) $(LDFLAGS) $(MNTMODLDFLAGS) -shared -Wl,--export-dynamic \
                         -o mount_osd_ldiskfs.so \
                         `$(AR) -t libmount_utils_ldiskfs.a` \
                         $(MNTMODLIBS) -lext2fs