Whamcloud - gitweb
LU-18685 deb: fix broken EXTRAFLAGS 22/57922/3
authorAke Sandgren <ake.sandgren@hpc2n.umu.se>
Wed, 29 Jan 2025 12:15:37 +0000 (13:15 +0100)
committerOleg Drokin <green@whamcloud.com>
Wed, 7 May 2025 21:11:47 +0000 (21:11 +0000)
A change to allow separate packages to be built has broken handling
of EXTRAFLAGS in debian/rules. It should always use:

 EXTRAFLAGS="${EXTRAFLAGS} ..."

Fixes: 1a2119c54e ("LU-17462 build: make some deb packages optional")
Test-Parameters: trivial
Signed-off-by: Ake Sandgren <ake.sandgren@hpc2n.umu.se>
Change-Id: I44aa60fea474ae046ba89a6502ba9b6c635c6918
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/57922
Reviewed-by: Timothy Day <timday@amazon.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Tested-by: Maloo <maloo@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
debian/rules

index 090667d..00ba6a6 100755 (executable)
@@ -222,13 +222,13 @@ configure-stamp: autogen-stamp debian/control.main debian/control.modules.in
                export EXTRAFLAGS="$${EXTRAFLAGS} --disable-mpitests" ; \
        fi; \
        if echo "$${DEB_BUILD_PROFILES}" | grep -q "notests"; then \
-               export EXTRAFLAGS="--disable-tests"; \
+               export EXTRAFLAGS="$${EXTRAFLAGS} --disable-tests"; \
        fi; \
        if echo "$${DEB_BUILD_PROFILES}" | grep -q "noutils"; then \
-               export EXTRAFLAGS="--disable-utils"; \
+               export EXTRAFLAGS="$${EXTRAFLAGS} --disable-utils"; \
        fi; \
        if echo "$${DEB_BUILD_PROFILES}" | grep -q "noiokit"; then \
-               export EXTRAFLAGS="--disable-iokit"; \
+               export EXTRAFLAGS="$${EXTRAFLAGS} --disable-iokit"; \
        fi; \
        if echo "$${DEB_BUILD_PROFILES}" | grep -q "zfs"; then \
                export EXTRAFLAGS="$${EXTRAFLAGS} --with-zfs=$${ZFS_SRC} --with-spl=$${SPL_SRC}"; \
@@ -553,13 +553,13 @@ kdist_config: prep-deb-files patch-stamp
                export EXTRAFLAGS="$${EXTRAFLAGS} --disable-mpitests" ; \
        fi; \
        if echo "$${DEB_BUILD_PROFILES}" | grep -q "notests"; then \
-               export EXTRAFLAGS="--disable-tests"; \
+               export EXTRAFLAGS="$${EXTRAFLAGS} --disable-tests"; \
        fi; \
        if echo "$${DEB_BUILD_PROFILES}" | grep -q "noutils"; then \
-               export EXTRAFLAGS="--disable-utils"; \
+               export EXTRAFLAGS="$${EXTRAFLAGS} --disable-utils"; \
        fi; \
        if echo "$${DEB_BUILD_PROFILES}" | grep -q "noiokit"; then \
-               export EXTRAFLAGS="--disable-iokit"; \
+               export EXTRAFLAGS="$${EXTRAFLAGS} --disable-iokit"; \
        fi; \
        if echo "$${DEB_BUILD_PROFILES}" | grep -q "zfs"; then \
                export EXTRAFLAGS="$${EXTRAFLAGS} --with-zfs=$${ZFS_SRC} --with-spl=$${SPL_SRC}"; \