LU-16082 ldiskfs: old-style EA inode handling fix

The upstream version of EA inodes support coming
with RHEL8 (linux kernel 4.18+) have a slightly different
implementation of EA inodes support and also have a
compatibility code to recognize old-style Lustre-only EAs.
Unfortunately the compatibility code is broken and makes
old xattr data unaccessible due to a wrong hash value check.

Lustre-change: https://review.whamcloud.com/48174
Lustre-commit: 76c3fa96dc30f21e95d80f9119972d7358975258

HPE-bug-id: LUS-11133
Signed-off-by: Alexander Zarochentsev <alexander.zarochentsev@hpe.com>
Change-Id: Icd6f93d4ebb33dcd03b58f9eb364905c18ae81dc
Reviewed-by: Alex Zhuravlev <bzzz@whamcloud.com>
Reviewed-by: Artem Blagodarenko <ablagodarenko@ddn.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-on: https://review.whamcloud.com/48412
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>

diff --git a/ldiskfs/kernel_patches/patches/rhel8/ext4-old_ea_inodes_handling_fix.patch b/ldiskfs/kernel_patches/patches/rhel8/ext4-old_ea_inodes_handling_fix.patch
new file mode 100644 (file)
index 0000000..ac3a58f
--- /dev/null
+++ b/ldiskfs/kernel_patches/patches/rhel8/ext4-old_ea_inodes_handling_fix.patch
@@ -0,0 +1,19 @@
+Index: linux-stage/fs/ext4/xattr.c
+===================================================================
+--- linux-stage.orig/fs/ext4/xattr.c
++++ linux-stage/fs/ext4/xattr.c
+@@ -415,10 +415,11 @@ static int ext4_xattr_inode_iget(struct
+ 
+       /*
+        * Check whether this is an old Lustre-style xattr inode. Lustre
+-       * implementation does not have hash validation, rather it has a
+-       * backpointer from ea_inode to the parent inode.
++       * implementation sets ea_inode->i_atime.tv_sec to 0
++       * (when md csum is off, means always)
++       * and backpointer from ea_inode to the parent inode.
+        */
+-      if (ea_inode_hash != ext4_xattr_inode_get_hash(inode) &&
++      if (ext4_xattr_inode_get_hash(inode) == 0 &&
+           EXT4_XATTR_INODE_GET_PARENT(inode) == parent->i_ino &&
+           inode->i_generation == parent->i_generation) {
+               ext4_set_inode_state(inode, EXT4_STATE_LUSTRE_EA_INODE);

diff --git a/ldiskfs/kernel_patches/series/ldiskfs-4.18-rhel8.4.series b/ldiskfs/kernel_patches/series/ldiskfs-4.18-rhel8.4.series
index 6856d42..2fe189e 100644 (file)
--- a/ldiskfs/kernel_patches/series/ldiskfs-4.18-rhel8.4.series
+++ b/ldiskfs/kernel_patches/series/ldiskfs-4.18-rhel8.4.series
@@ -31,3 +31,4 @@ base/ext4-projid-xattrs.patch
 rhel8.4/ext4-enc-flag.patch
 base/ext4-delayed-iput.patch
 rhel8.5/ext4-filename-encode.patch
+rhel8/ext4-old_ea_inodes_handling_fix.patch