Whamcloud - gitweb
LU-17285 obdclass: remove debug from obd_get_at_* 06/53106/4
authorAlex Zhuravlev <bzzz@whamcloud.com>
Mon, 13 Nov 2023 04:48:40 +0000 (07:48 +0300)
committerOleg Drokin <green@whamcloud.com>
Sun, 4 Feb 2024 08:33:17 +0000 (08:33 +0000)
Removing debugging CDEBUG() from obd_get_at_*() helpers.
Messages like the following:
00010000:00100000:0.0:1699657756.854481:0:27978:0:
(ldlm_request.c:181:ldlm_cp_timeout()) NULL obd

Fixes: 0f2bc318d7 ("LU-15246 ptlrpc: per-device adaptive timeout parameters")
Test-Parameters: trivial
Signed-off-by: Alex Zhuravlev <bzzz@whamcloud.com>
Change-Id: Iaaa964d4e3ca62de5fb273f865d7cd4c3a4f9a29
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/53106
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Timothy Day <timday@amazon.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/include/obd.h

index 564b391..4438d4e 100644 (file)
@@ -758,27 +758,19 @@ struct obd_device {
 
 #define obd_get_at_min(obd) ({ \
        struct obd_device *_obd = obd; \
-       if (_obd == NULL) \
-               CDEBUG(D_RPCTRACE, "NULL obd\n"); \
        _obd && _obd->obd_at_min ? _obd->obd_at_min : at_min; \
 })
 #define obd_get_at_max(obd) ({\
        struct obd_device *_obd = obd; \
-       if (_obd == NULL) \
-               CDEBUG(D_RPCTRACE, "NULL obd\n"); \
        _obd && _obd->obd_at_max ? _obd->obd_at_max : at_max; \
 })
 #define obd_get_at_history(obd) ({ \
        struct obd_device *_obd = obd; \
-       if (_obd == NULL) \
-               CDEBUG(D_RPCTRACE, "NULL obd\n"); \
        _obd && _obd->obd_at_history ? _obd->obd_at_history : at_history; \
 })
 extern unsigned int ldlm_enqueue_min;
 #define obd_get_ldlm_enqueue_min(obd) ({ \
        struct obd_device *_obd = obd; \
-       if (_obd == NULL) \
-               CDEBUG(D_RPCTRACE, "NULL obd\n"); \
        _obd && _obd->obd_ldlm_enqueue_min ? _obd->obd_ldlm_enqueue_min : \
                                             ldlm_enqueue_min; \
 })